diff --git a/pkg/clientaccess/token.go b/pkg/clientaccess/token.go index d9ab822b9cde..8538c8e476e3 100644 --- a/pkg/clientaccess/token.go +++ b/pkg/clientaccess/token.go @@ -165,11 +165,15 @@ func hashCA(b []byte) (string, error) { // ParseUsernamePassword returns the username and password portion of a token string, // along with a bool indicating if the token was successfully parsed. +// Kubeadm-style tokens have ID/Secret not Username/Password and therefore will return false (invalid). func ParseUsernamePassword(token string) (string, string, bool) { info, err := parseToken(token) if err != nil { return "", "", false } + if info.BootstrapTokenString != nil { + return "", "", false + } return info.Username, info.Password, true } diff --git a/pkg/clientaccess/token_test.go b/pkg/clientaccess/token_test.go index c538de164cad..f004f1bc2a93 100644 --- a/pkg/clientaccess/token_test.go +++ b/pkg/clientaccess/token_test.go @@ -294,6 +294,7 @@ func Test_UnitUserPass(t *testing.T) { {"K10XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX::username:password", "username", "password", true}, {"password", "", "password", true}, {"K10X::x", "", "", false}, + {"aaaaaa.bbbbbbbbbbbbbbbb", "", "", false}, } for _, testCase := range testCases { diff --git a/pkg/cluster/storage.go b/pkg/cluster/storage.go index 56c7a999a565..b10fe4fc75e1 100644 --- a/pkg/cluster/storage.go +++ b/pkg/cluster/storage.go @@ -271,7 +271,7 @@ func readTokenFromFile(serverToken, certs, dataDir string) (string, error) { func normalizeToken(token string) (string, error) { _, password, ok := clientaccess.ParseUsernamePassword(token) if !ok { - return password, errors.New("failed to normalize token; must be in format K10::: or ") + return password, errors.New("failed to normalize server token; must be in format K10::: or ") } return password, nil @@ -286,7 +286,7 @@ func migrateOldTokens(ctx context.Context, bootstrapList []client.Value, storage for _, bootstrapKV := range bootstrapList { // checking for empty string bootstrap key if string(bootstrapKV.Key) == emptyStringKey { - logrus.Warn("bootstrap data encrypted with empty string, deleting and resaving with token") + logrus.Warn("Bootstrap data encrypted with empty string, deleting and resaving with token") if err := doMigrateToken(ctx, storageClient, bootstrapKV, "", emptyStringKey, token, tokenKey); err != nil { return err } diff --git a/tests/e2e/startup/startup_test.go b/tests/e2e/startup/startup_test.go index f33fedb02605..a2d3a19b1375 100644 --- a/tests/e2e/startup/startup_test.go +++ b/tests/e2e/startup/startup_test.go @@ -246,6 +246,18 @@ var _ = Describe("Various Startup Configurations", Ordered, func() { Expect(err).NotTo(HaveOccurred()) }) }) + Context("Verify server fails to start with bootstrap token", func() { + It("Fails to start with a meaningful error", func() { + tokenYAML := "token: aaaaaa.bbbbbbbbbbbbbbbb" + err := StartK3sCluster(append(serverNodeNames, agentNodeNames...), tokenYAML, tokenYAML) + Expect(err).To(HaveOccurred()) + Expect(err).To(ContainSubstring("failed to normalize server token")) + }) + It("Kills the cluster", func() { + err := KillK3sCluster(append(serverNodeNames, agentNodeNames...)) + Expect(err).NotTo(HaveOccurred()) + }) + }) }) var failed bool