Reporter onBrowserComplete without onBrowserStart

[vojtajina]

It is possible this happens, if browser errors/crashes/get timeout-ed before firing "start" (start happens after all the specs are loaded and test framework kicks off the execution).

Reporters don's expect this, for instance junit reporter creates "xml" object per browser in onBrowserStart and then assumes it is there in onBrowserComplete. Similar happens with coverage reporter and probably many others.

I suggest to handle this in lib/browser.js, if a browser tries to emit "complete" without "start", we should emit "start" event first.

[sylvain-hamel]

@vojtajina FYI: I submitted PR karma-runner/karma-junit-reporter#17 to fix that in the junit reporter before I saw this issue here.

[vojtajina]

That's all right. But we should still fix it in karma core.

[dignifiedquire]

Closing due to inactivity

[arobinson]

This is still an issue and we can reproduce the issue in a Jenkins run. I debugged the karma-junit-reporter code and found that when it doesn't write the report, its initializeXmlForBrowser is never executed.

This function is called by:

  // "run_start" - a test run is beginning for all browsers
  this.onRunStart = function (browsers) {
    // TODO(vojta): remove once we don't care about Karma 0.10
    browsers.forEach(initializeXmlForBrowser)
  }

  // "browser_start" - a test run is beginning in _this_ browser
  this.onBrowserStart = function (browser) {
    initializeXmlForBrowser(browser)
  }

So we have hit this use case where onBrowserStart is not invoked, but onBrowserComplete is invoked.

[arobinson]

Can this be re-opened or should a new issue be filed? Not sure why this was closed without the issue being addressed.