Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing download fa icon #1148

Closed
7 of 10 tasks
ivomasterche opened this issue Jan 4, 2018 · 1 comment
Closed
7 of 10 tasks

missing download fa icon #1148

ivomasterche opened this issue Jan 4, 2018 · 1 comment

Comments

@ivomasterche
Copy link

ivomasterche commented Jan 4, 2018

Prerequisites

  • I have searched for similar issues in both open and closed tickets and cannot find a duplicate.
  • The issue still exists against the latest master branch of bootstrap-fileinput.
  • This is not an usage question. I confirm having read the plugin documentation and demos.
  • This is not a general programming / coding question. (Those should be directed to the webtips Q & A forum).
  • I have attempted to find the simplest possible steps to reproduce the issue.
  • I have included a failing test as a pull request (Optional).

Steps to reproduce the issue

1.use fa theme
2.add downloadUrl

Expected behavior and actual behavior

When I follow those steps, I see...

The button is empty

I was expecting...

To see download icon

Environment

Browsers

  • Google Chrome
  • Mozilla Firefox
  • Internet Explorer
  • Safari

Libraries

  • jQuery version: 3.2.1
  • bootstrap-fileinput version: 4.4.7

If i add

downloadIcon: '<i class="fa fa-arrow-circle-down"></i>',

to

$.fn.fileinputThemes.fa = { fileActionSettings: { ... }}

it works.

@kartik-v
Copy link
Owner

kartik-v commented Feb 3, 2018

There is an enhancement provided for the font awesome themes above.

But note for your use case (on overriding options) please ensure you have understood the usage right as mentioned in this comment.

You need to follow the FIRST HIGHLIGHTED note in the usage.

If you are initializing the plugin separately via javascript, then DO NOT ATTACH the css class file to the input (as it will result in duplicate initializations and the javascript code maybe skipped).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants