Creation of unintentional, buggy regions #3642
Comments
|
I wasn't able to reproduce this in Chrome (mac/touchpad) in this example: https://wavesurfer.xyz/examples/?regions.js Is there any additional code that you added that might affect it? Can you make a reproducible example on codepen? |
|
hey @katspaugh. I have around 800 lines of code that I have used to create an entire application using the library. Could it be that I am trying to overwork the |
|
A few days ago there was a refactoring of the draggable function, so it may well be a regression. The problem is I don't know how to reproduce it. Could you try going back to v7.7.6 and seeing if the bug goes away? |
|
i just tried all versions of |
|
Is your app available at some URL? |
|
noo i have not deployed it yet :/ |
|
I was able to reproduce the bug on https://wavesurfer.xyz/examples/?regions.js when I try to create several regions quickly (I've just removed the code that generates the predefined regions). It seems that when clicking on the "ghost" region, it plays the region which was previously selected. I'm on Ubuntu using Chrome with a mouse. 2024-04-09.09-47-52.mp4 |
|
@VaysseRobin @ManimMadhav can you reproduce it with this example? https://wavesurfer.xyz/examples/?064352f48990781f8e5328ed18f4301b (wavesurfer version prior to the draggable refactoring) |
|
No @katspaugh , I can't reproduce the error here in the link you have provided. |
|
I can't reproduce it either in this older version. |
|
I can reproduce this error in my code though, while using version |
|
I have the same problem. (Ubuntu + chrome v123 + mouse) |
|
Thanks for confirming @leyiang, I’ll revert the commit that caused this. |
|
Could you guys try on this branch? https://revert-draggable.wavesurfer-js.pages.dev/#regions.js |
I tried it, and there were no issues. (at least for me) |
|
I've published v7.7.11 with a fix. |
|
uhh when will this version be available on unpkg.com? |
|
Unpkg seems to have been having issues lately, you migth want to switch to some other CDN (there are some suggestions in #3650). |
|
have they not yet been updated with v7.7.11? |
|
My bad, the package wasn’t published properly. I’ve just published 7.7.11 for real. |
|
thank you so much for this speedy fix @katspaugh! |
Bug description:
Hi all, I have encountered a problem while working with this library which I believe might be a bug. While creating regions, there seems to be an issue with creation of regions that can be called rogue. I am attaching a video of how the unintended behaviour occurs. You can view the ID of the region that is being clicked on in the
consoleon the right side.bug-wavesurfer.mp4
You can see how the regions break into two while creating them. I have used a
region-clickevent to check theregion.idof the regions so created. When a region breaks into two, the first half of the region does not seem to have an ID which makes removal of that region impossible unless I restart the program (by refreshing the webpage).You can see how I click on
Clear All Regionsat the end but somehow, those rogue regions do not seem to go away. Even when I click on those regions to view their ID, nothing appears in the console.Environment:
import WaveSurfer from 'https://unpkg.com/wavesurfer.js@7/dist/wavesurfer.esm.js'Minimal code snippet:
Regions get created by dragging:
Region click code:
Clearing all regions code:
Expected result:
Regions shouldn't be breaking into two for intended use.
Obtained result:
Region created split into two.
PS: Do let me know if I can make any clarifications, it's my first time opening an issue on GitHub. Thank you!
The text was updated successfully, but these errors were encountered: