Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CRDs to write events to the resources #3764

Closed
tomkerkhove opened this issue Oct 21, 2022 · 9 comments · Fixed by #4829
Closed

Improve CRDs to write events to the resources #3764

tomkerkhove opened this issue Oct 21, 2022 · 9 comments · Fixed by #4829
Assignees
Labels
feature All issues for new features that have been committed to feature-request All issues for new features that have not been committed to needs-discussion stale-bot-ignore All issues that should not be automatically closed by our stale bot

Comments

@tomkerkhove
Copy link
Member

Proposal

Improve CRDs to write events to the resources so that cluster admins/app operators can inspect the CRDs and see what is going on.

Things that come to mind is:

  • Scale to/from 0
  • Authentication failures
  • Fallback of trigger
  • Triggers becoming active
  • ...

Use-Case

Improve experience for cluster admins/app operators troubleshooting issues.

Anything else?

No response

@tomkerkhove tomkerkhove added needs-discussion feature-request All issues for new features that have not been committed to labels Oct 21, 2022
@zroubalik
Copy link
Member

I suppose this proposal is about improving the Status of the CRs created by users in the cluster. Not about the CRDs created by installation. I agree, the status exposed by each resource should be improved.

@tomkerkhove
Copy link
Member Author

That, and provide updates in the event section around scaling - Actually what is proposed in #3822 to bring it closer to the resource.

Think this, but tailored to KEDA/scaling actions:
image

@stale
Copy link

stale bot commented Jan 6, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale All issues that are marked as stale due to inactivity label Jan 6, 2023
@zroubalik zroubalik added the stale-bot-ignore All issues that should not be automatically closed by our stale bot label Jan 6, 2023
@stale stale bot removed the stale All issues that are marked as stale due to inactivity label Jan 6, 2023
@tomkerkhove tomkerkhove added feature-request All issues for new features that have not been committed to feature All issues for new features that have been committed to and removed feature-request All issues for new features that have not been committed to labels Jan 6, 2023
@tomkerkhove
Copy link
Member Author

Example use-case: #4074 (reply in thread)

@tomkerkhove
Copy link
Member Author

Any thoughts on this @kedacore/keda-maintainers?

@zroubalik
Copy link
Member

+1

1 similar comment
@JorTurFer
Copy link
Member

+1

@SpiritZhou SpiritZhou self-assigned this Jul 11, 2023
@SpiritZhou
Copy link
Contributor

HI @tomkerkhove I noticed that some events are added. Here are the event list and example: https://github.com/kedacore/keda/blob/main/pkg/eventreason/eventreason.go
image

Could you specify what events should be added?

@JorTurFer
Copy link
Member

JorTurFer commented Jul 26, 2023

I think that some of them like:

  • KEDAScaleTargetActivated
  • KEDAScaleTargetDeactivated
  • ScaledJobCheckFailed
  • ScaledObjectCheckFailed
  • ScaledObjectReady
  • ScaledJobReady

But also other new events for things like failures on authentication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature All issues for new features that have been committed to feature-request All issues for new features that have not been committed to needs-discussion stale-bot-ignore All issues that should not be automatically closed by our stale bot
Projects
Status: Ready To Ship
Development

Successfully merging a pull request may close this issue.

4 participants