Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Prometheus metrics for ScaledJob #4798

Closed
zroubalik opened this issue Jul 14, 2023 · 12 comments · Fixed by #4913
Closed

Implement Prometheus metrics for ScaledJob #4798

zroubalik opened this issue Jul 14, 2023 · 12 comments · Fixed by #4913
Assignees

Comments

@zroubalik
Copy link
Member

Proposal

ScaledObject expose a bunch of Prometheus metrics, would be nice if we expose the same and metrics for ScaledJob as well.

https://keda.sh/docs/2.11/operate/prometheus/

Use-Case

No response

Is this a feature you are interested in implementing yourself?

Maybe

Anything else?

No response

@zroubalik zroubalik added needs-discussion feature-request All issues for new features that have not been committed to labels Jul 14, 2023
@zroubalik zroubalik changed the title Implement Prometheus metrics for ScaledJov Implement Prometheus metrics for ScaledJob Jul 14, 2023
@zroubalik
Copy link
Member Author

@yoongon I recall you were interested in more stuff to contribute, this might be a good one.

@yoongon
Copy link
Contributor

yoongon commented Jul 15, 2023

@zroubalik Awesome. I appreciate it. Could you assign it to me?

@yoongon
Copy link
Contributor

yoongon commented Jul 24, 2023

Hi @zroubalik Thanks for giving this opportunity. I filed a PR(#4817). Please check when you are available. Thanks :)

@tomkerkhove
Copy link
Member

Thank you!

@tomkerkhove tomkerkhove removed feature-request All issues for new features that have not been committed to needs-discussion labels Aug 17, 2023
@stale
Copy link

stale bot commented Oct 16, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale All issues that are marked as stale due to inactivity label Oct 16, 2023
@stale
Copy link

stale bot commented Oct 24, 2023

This issue has been automatically closed due to inactivity.

@stale stale bot closed this as completed Oct 24, 2023
@zroubalik zroubalik reopened this Oct 24, 2023
@stale stale bot removed the stale All issues that are marked as stale due to inactivity label Oct 24, 2023
@geoffrey1330
Copy link
Contributor

Hi @zroubalik Could you please assign this issue to me.

@zroubalik
Copy link
Member Author

Hi @zroubalik Could you please assign this issue to me.

@yoongon works on this at the moment

@geoffrey1330
Copy link
Contributor

Alright

@geoffrey1330
Copy link
Contributor

@zroubalik maybe you could suggest an issue for me to look into.

Copy link

stale bot commented Dec 29, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale All issues that are marked as stale due to inactivity label Dec 29, 2023
Copy link

stale bot commented Jan 5, 2024

This issue has been automatically closed due to inactivity.

@stale stale bot closed this as completed Jan 5, 2024
@zroubalik zroubalik reopened this Jan 8, 2024
@stale stale bot removed the stale All issues that are marked as stale due to inactivity label Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready To Ship
Development

Successfully merging a pull request may close this issue.

4 participants