From 0ce5bd5ee8156d081f9b8e926b82080a093ba123 Mon Sep 17 00:00:00 2001 From: Merel Theisen Date: Tue, 15 Oct 2024 10:33:42 +0100 Subject: [PATCH 1/3] Update PR template with checkbox for core dataset contribution Signed-off-by: Merel Theisen --- .github/PULL_REQUEST_TEMPLATE.md | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 7faf3e035..9e87660b7 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -10,3 +10,4 @@ - [ ] Updated the documentation to reflect the code changes - [ ] Added a description of this change in the relevant `RELEASE.md` file - [ ] Added tests to cover my changes +- [ ] Is this a PR to contribute a dataset to the core datasets? Then it requires a TSC vote. From d9023d780769c10c5d109795a4785c098ee19a3c Mon Sep 17 00:00:00 2001 From: Merel Theisen <49397448+merelcht@users.noreply.github.com> Date: Tue, 15 Oct 2024 14:10:23 +0100 Subject: [PATCH 2/3] Update .github/PULL_REQUEST_TEMPLATE.md Co-authored-by: Deepyaman Datta Signed-off-by: Merel Theisen <49397448+merelcht@users.noreply.github.com> --- .github/PULL_REQUEST_TEMPLATE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 9e87660b7..1eea0ed9e 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -10,4 +10,4 @@ - [ ] Updated the documentation to reflect the code changes - [ ] Added a description of this change in the relevant `RELEASE.md` file - [ ] Added tests to cover my changes -- [ ] Is this a PR to contribute a dataset to the core datasets? Then it requires a TSC vote. +- [ ] Received approvals from at least half of the TSC (required for adding a new, non-experimental dataset) From a1d46fb59b3833f5f9a213dc86e5d11d040c5608 Mon Sep 17 00:00:00 2001 From: Merel Theisen Date: Tue, 15 Oct 2024 14:43:14 +0100 Subject: [PATCH 3/3] Fix lint Signed-off-by: Merel Theisen --- .github/PULL_REQUEST_TEMPLATE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 1eea0ed9e..6723cb70f 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -10,4 +10,4 @@ - [ ] Updated the documentation to reflect the code changes - [ ] Added a description of this change in the relevant `RELEASE.md` file - [ ] Added tests to cover my changes -- [ ] Received approvals from at least half of the TSC (required for adding a new, non-experimental dataset) +- [ ] Received approvals from at least half of the TSC (required for adding a new, non-experimental dataset)