Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MVP implementation of meganav navigation between documentation subprojects #3024

Closed
stichbury opened this issue Sep 8, 2023 · 7 comments
Closed
Assignees
Labels
Component: Documentation 📄 Issue/PR for markdown and API documentation Issue: Feature Request New feature or improvement to existing feature

Comments

@stichbury
Copy link
Contributor

stichbury commented Sep 8, 2023

Description

This is an implementation ticket to accompany the (hopefully minimal) design effort needed for #3017 to create a navigation between Kedro framework docs, datasets docs and viz docs (no need for the navigation option for deployment right now). This is part of the subproject effort in the parent ticket #2600 which improves the process of building/releasing docs and brings them closer to their packages.

I've created it as part of the Framework repo and associated "Documentation subprojects" milestone but it's in the Viz project as it requires front-end engineering.

Will leave @tynandebold to size and @NeroOkwa to prioritise and determine when it can start.

@stichbury stichbury added Component: Documentation 📄 Issue/PR for markdown and API documentation Issue: Feature Request New feature or improvement to existing feature labels Sep 8, 2023
@stichbury stichbury added this to the Documentation subprojects milestone Sep 8, 2023
@stichbury
Copy link
Contributor Author

cc @astrojuanlu @stephkaiser for visibility.

@vladimir-mck
Copy link

vladimir-mck commented Oct 11, 2023

I successfully implemented the desktop layout as outlined here with minimal adjustments.

Screenshot 2023-10-11 at 14 12 29

It required new CSS for the header and some to hide the logo and search bar in the sidebar. Additionally, the header required the new HTML. This new HTML should be added within the {%- block extrabody %} section of the layout.html file.

Regarding the documentation for Viz and Framework being split and linked through the navigation, it implies the need for shared HTML and CSS for that section of code. How should we proceed with sharing the header HTML and CSS?

As for mobile navigation, by default it is handled in the sidebar and adding new code in the sidebar is not possible within the current theme without completely overwriting the layout.html file. It is possible to add the 3 main links in the sidebar with javascript. How should I address this?

@astrojuanlu @stichbury @tynandebold

@astrojuanlu
Copy link
Member

Thanks a lot @vladimir-mck , this looks pristine! (Honestly cannot believe my strawman proposal is seeing the light of day 😄)

There was a plan about sharing the CSS in #3016, however I'm not sure if the proposal there is good enough to share the HTML blocks in the templates as well. If it isn't, we could go back to the idea of creating a custom Sphinx theme.

@stichbury
Copy link
Contributor Author

stichbury commented Oct 12, 2023

This looks great, thank you! 🌟

I'd prefer to defer the queries on sharing HTML and mobile navigation to @tynandebold

I think it would make sense for @stephkaiser to take a look at this point. Do you have a preview deploy from a PR that she could review please, @vladimir-mck ? There is an understanding that this is an interim solution as we have plans for the docs beyond this change, but clearly if there's any small tweak needed for design, now's the time to raise it.

Edit: Addressed by this PR, which has a preview link

@tynandebold
Copy link
Member

I don't think we can share HTML in the same way we can share CSS, so for now and to unlock this work, my recommendation would be we copy the necessary HTML we need in the three projects and share the CSS from the centralized place.

For mobile navigation, let's add the three main links to the top of the sidebar on mobile-sized screens and hide them with CSS on desktop.

@stichbury
Copy link
Contributor Author

Now using that shareable CSS here for the Framework (draft PR) and in the draft Viz docs.

@stichbury
Copy link
Contributor Author

This is now complete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Documentation 📄 Issue/PR for markdown and API documentation Issue: Feature Request New feature or improvement to existing feature
Projects
Status: Done
Development

No branches or pull requests

4 participants