Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specific Slack channel notification per deployment #142

Closed
skamoen opened this issue Feb 22, 2018 · 3 comments
Closed

Specific Slack channel notification per deployment #142

skamoen opened this issue Feb 22, 2018 · 3 comments

Comments

@skamoen
Copy link

skamoen commented Feb 22, 2018

Basically as described in #113, however that ticket was closed with only a separate approval feature.

I'd like to set channels for each deployment so that deployments for application-a sends notifications to a specific slack channel, and application-b to another.

@rusenask
Copy link
Collaborator

Hi, sorry for closing that issue without completely resolving it.

It's a good idea to have an ability to override default channels by labels or annotations. I wonder what to do about Helm though, would this be configurable at chart or somewhere else. Nevertheless we could add labels or annotations to the event:

type EventNotification struct {
	Name      string       `json:"name"`
	Message   string       `json:"message"`
	CreatedAt time.Time    `json:"createdAt"`
	Type      Notification `json:"type"`
	Level     Level        `json:"level"`
        Labels map[string]string
}

And overwrite more than one thing.

@rusenask
Copy link
Collaborator

@skamoen added this in #146, docs: https://keel.sh/v1/guide/documentation.html#Overriding-default-channels-per-deployment. Could you try it out and see whether this is something that you wanted?

@skamoen
Copy link
Author

skamoen commented Feb 25, 2018

Yes. This is perfect. Thanks a lot!

@skamoen skamoen closed this as completed Feb 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants