Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS ECR does not conform to v2 registry spec and therefore returns an 'invalid checksum' error #173

Closed
cparedes opened this issue Mar 30, 2018 · 2 comments

Comments

@cparedes
Copy link

AWS ECR does not return a Docker-Content-Digest header and therefore doesn't conform to v2 API spec.

We could modify this to look elsewhere for digest info: https://github.com/rusenask/docker-registry-client/blob/bf1d91b397917b39e5f0478dd679c8aa224ca91e/registry/manifest.go#L92, but I'm not a huge fan of that option.

Same thing for

manifestDigest, err := hub.ManifestDigest(opts.Name, opts.Tag)

v1 API doesn't seem to work at all on ECR either.

What do folks think?

@cparedes
Copy link
Author

This should fix the issue, but still need to test: rusenask/docker-registry-client#1

@rusenask
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants