From 279366a0b279658b52e646c637a56489e825ee67 Mon Sep 17 00:00:00 2001 From: Brian Anderson Date: Mon, 13 Jan 2014 19:44:18 -0800 Subject: [PATCH 1/2] mk: Make TESTNAME and VERBOSE work with android. Closes #10957 --- mk/tests.mk | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/mk/tests.mk b/mk/tests.mk index d50f9878bd162..65cf751b57ba6 100644 --- a/mk/tests.mk +++ b/mk/tests.mk @@ -445,17 +445,17 @@ check-stage$(1)-T-$(2)-H-$(3)-$(4)-exec: $$(call TEST_OK_FILE,$(1),$(2),$(3),$(4 $$(call TEST_OK_FILE,$(1),$(2),$(3),$(4)): \ $(3)/stage$(1)/test/$(4)test-$(2)$$(X_$(2)) @$$(call E, run: $$< via adb) - @$(CFG_ADB) push $$< $(CFG_ADB_TEST_DIR) - @$(CFG_ADB) shell '(cd $(CFG_ADB_TEST_DIR); LD_LIBRARY_PATH=. \ + $$(Q)$(CFG_ADB) push $$< $(CFG_ADB_TEST_DIR) + $$(Q)$(CFG_ADB) shell '(cd $(CFG_ADB_TEST_DIR); LD_LIBRARY_PATH=. \ ./$$(notdir $$<) \ --logfile $(CFG_ADB_TEST_DIR)/check-stage$(1)-T-$(2)-H-$(3)-$(4).log \ - $$(call CRATE_TEST_EXTRA_ARGS,$(1),$(2),$(3),$(4)))' \ + $$(call CRATE_TEST_EXTRA_ARGS,$(1),$(2),$(3),$(4)) $(TESTARGS))' \ > tmp/check-stage$(1)-T-$(2)-H-$(3)-$(4).tmp - @cat tmp/check-stage$(1)-T-$(2)-H-$(3)-$(4).tmp - @touch tmp/check-stage$(1)-T-$(2)-H-$(3)-$(4).log - @$(CFG_ADB) pull $(CFG_ADB_TEST_DIR)/check-stage$(1)-T-$(2)-H-$(3)-$(4).log tmp/ - @$(CFG_ADB) shell rm $(CFG_ADB_TEST_DIR)/check-stage$(1)-T-$(2)-H-$(3)-$(4).log - @$(CFG_ADB) pull $(CFG_ADB_TEST_DIR)/$$(call TEST_RATCHET_FILE,$(1),$(2),$(3),$(4)) tmp/ + $$(Q)cat tmp/check-stage$(1)-T-$(2)-H-$(3)-$(4).tmp + $$(Q)touch tmp/check-stage$(1)-T-$(2)-H-$(3)-$(4).log + $$(Q)$(CFG_ADB) pull $(CFG_ADB_TEST_DIR)/check-stage$(1)-T-$(2)-H-$(3)-$(4).log tmp/ + $$(Q)$(CFG_ADB) shell rm $(CFG_ADB_TEST_DIR)/check-stage$(1)-T-$(2)-H-$(3)-$(4).log + $$(Q)$(CFG_ADB) pull $(CFG_ADB_TEST_DIR)/$$(call TEST_RATCHET_FILE,$(1),$(2),$(3),$(4)) tmp/ @if grep -q "result: ok" tmp/check-stage$(1)-T-$(2)-H-$(3)-$(4).tmp; \ then \ rm tmp/check-stage$(1)-T-$(2)-H-$(3)-$(4).tmp; \ From 062b0fd2649e7de848996d1193e4b462db33b2b1 Mon Sep 17 00:00:00 2001 From: Brian Anderson Date: Mon, 13 Jan 2014 19:45:08 -0800 Subject: [PATCH 2/2] std: Ignore bind error tests on android. #11530 --- src/libstd/io/net/tcp.rs | 3 ++- src/libstd/io/net/udp.rs | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/libstd/io/net/tcp.rs b/src/libstd/io/net/tcp.rs index 023a9bddca96e..b901ea99cbe3c 100644 --- a/src/libstd/io/net/tcp.rs +++ b/src/libstd/io/net/tcp.rs @@ -136,6 +136,7 @@ mod test { use io::*; use prelude::*; + // FIXME #11530 this fails on android because tests are run as root iotest!(fn bind_error() { let mut called = false; io_error::cond.trap(|e| { @@ -147,7 +148,7 @@ mod test { assert!(listener.is_none()); }); assert!(called); - } #[ignore(cfg(windows))]) + } #[ignore(cfg(windows))] #[ignore(cfg(target_os = "android"))]) iotest!(fn connect_error() { let mut called = false; diff --git a/src/libstd/io/net/udp.rs b/src/libstd/io/net/udp.rs index 8a866c2a3573b..952ca7f730ed7 100644 --- a/src/libstd/io/net/udp.rs +++ b/src/libstd/io/net/udp.rs @@ -99,6 +99,7 @@ mod test { use super::*; use io::net::ip::{SocketAddr}; + // FIXME #11530 this fails on android because tests are run as root iotest!(fn bind_error() { let mut called = false; io_error::cond.trap(|e| { @@ -110,7 +111,7 @@ mod test { assert!(socket.is_none()); }); assert!(called); - } #[ignore(cfg(windows))]) + } #[ignore(cfg(windows))] #[ignore(cfg(target_os = "android"))]) iotest!(fn socket_smoke_test_ip4() { let server_ip = next_test_ip4();