markdown.heading missing in VS Code theme

[TomMoeras]

The markdown.heading scope appears to be missing from the Flexoki-Dark-color-theme.json file. When using a markdown heading like # Heading, the heading is white.

I've manually added the markdown.heading scope to my JSON file. However, I've noticed that the "#" still remains in the default white color instead of the heading color.

[Railly]

I was using entity.name.section.markdown for matching that token. I can add markdown.heading, but can you show me your textmate scopes for both the "#" and the heading? Just like this:

[TomMoeras]

Thank you for your response.

I noticed that the issue seemed specific to Quarto markdown files. After experimenting, I was able to get the desired formatting by adding the following to the theme's JSON:

{
  "scope": "markup.heading",
  "settings": {
    "fontStyle": "bold",
    "foreground": "#D0A215"
  }
},
{
  "scope": [
    "punctuation.definition.heading"
  ],
  "settings": {
    "foreground": "#CE5D97"
  }
}

Additionally, defining both entity.name.section and entity.name.section.markdown separately in the theme configuration also seemed to address the issue.

To be honest, theme development and TextMate scopes are not my expertise. However, I found it interesting that Quarto(md)-specific elements, although not explicitly defined, still get formatted correctly by using .markdown scopes. It makes me wonder how the default theme handles this as there it is rendered as expected by using .markdown scopes.

As for the textmate scopes you asked for:

For the # character:

For the heading:

[Railly]

It makes me wonder how the default theme handles this as there it is rendered as expected by using .markdown scopes

Yup, you nailed it. I was working on a new theme generator for VSCode yesterday and I can confirm the better defaults you have, the less specificity you need.

I reduced the amount of lines from 1200 to 560 approximately, and obtained a similar, or even a better result.

I'll be releasing an update on this soon.