Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: detection of color support #259

Merged
merged 2 commits into from
Mar 6, 2023
Merged

fix: detection of color support #259

merged 2 commits into from
Mar 6, 2023

Conversation

tasshi-me
Copy link
Member

@tasshi-me tasshi-me commented Mar 3, 2023 •
edited
Loading

Why

#258

What

cli-kintone uses console.error (stderr) for log output.

According to the documentation of chalk, we have to use chalkStderr for stderr.

https://github.com/chalk/chalk#chalkstderr-and-supportscolorstderr

How to test

yarn install
yarn build

./bin/cli-kintone-macos record delete --app 123 > log.txt
# Check log.txt doesn't include color codes

Checklist

  • Read CONTRIBUTING.md
  • Updated documentation if it is required.
  • Added tests if it is required.
  • Passed yarn lint and yarn test on the root directory.

@tasshi-me tasshi-me requested a review from a team March 3, 2023 10:03
@tasshi-me tasshi-me self-assigned this Mar 3, 2023
@tasshi-me tasshi-me linked an issue Mar 3, 2023 that may be closed by this pull request
The detection of color support doesn't work correctly #258
Closed
@tasshi-me tasshi-me requested review from hung-cybo and removed request for a team March 6, 2023 02:48
hung-cybo
hung-cybo approved these changes Mar 6, 2023
View reviewed changes
Copy link
Contributor

@hung-cybo hung-cybo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hung-cybo hung-cybo merged commit f5fb446 into main Mar 6, 2023
@hung-cybo hung-cybo deleted the fix/detection-of-color-support branch March 6, 2023 08:01
@github-actions github-actions bot mentioned this pull request Mar 6, 2023
Merged
@github-actions github-actions bot mentioned this pull request Aug 2, 2023
Merged
@github-actions github-actions bot mentioned this pull request Aug 9, 2023
Closed
@github-actions github-actions bot mentioned this pull request Aug 23, 2023
Closed
@trigger-github-actions-release trigger-github-actions-release bot mentioned this pull request Sep 6, 2023
Closed
@trigger-github-actions-release trigger-github-actions-release bot mentioned this pull request Sep 13, 2023
Closed
@tasshi-me tasshi-me mentioned this pull request Sep 14, 2023
Closed
4 tasks
@trigger-github-actions-release trigger-github-actions-release bot mentioned this pull request Sep 27, 2023
Merged
@trigger-github-actions-release trigger-github-actions-release bot mentioned this pull request Oct 4, 2023
Merged
@trigger-github-actions-release trigger-github-actions-release bot mentioned this pull request Oct 16, 2023
Merged
@trigger-github-actions-release trigger-github-actions-release bot mentioned this pull request Oct 25, 2023
Merged
@trigger-github-actions-release trigger-github-actions-release bot mentioned this pull request Nov 1, 2023
Merged
@trigger-github-actions-release trigger-github-actions-release bot mentioned this pull request Nov 15, 2023
Merged
@trigger-github-actions-release trigger-github-actions-release bot mentioned this pull request Dec 6, 2023
Merged
@trigger-github-actions-release trigger-github-actions-release bot mentioned this pull request Dec 27, 2023
Merged
This was referenced Jan 17, 2024
Merged
Merged
This was referenced Jan 31, 2024
Merged
Merged
@trigger-github-actions-release trigger-github-actions-release bot mentioned this pull request Feb 21, 2024
Merged
@trigger-github-actions-release trigger-github-actions-release bot mentioned this pull request Apr 3, 2024
Merged
This was referenced Jun 12, 2024
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hung-cybo hung-cybo hung-cybo approved these changes

Assignees

@tasshi-me tasshi-me

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The detection of color support doesn't work correctly
2 participants
@tasshi-me @hung-cybo