Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minerva vulnerability #411

Closed
J08nY opened this issue Oct 3, 2019 · 2 comments
Closed

Minerva vulnerability #411

J08nY opened this issue Oct 3, 2019 · 2 comments

Comments

@J08nY
Copy link

J08nY commented Oct 3, 2019

This library is very likely vulnerable to a timing attack on ECDSA signature generation which is described at:

https://minerva.crocs.fi.muni.cz

The ECDSA signing functions call the ECPointFp multiply method at:

https://github.com/kjur/jsrsasign/blob/master/src/ecdsa-modified-1.0.js#L214
https://github.com/kjur/jsrsasign/blob/master/src/ecdsa-modified-1.0.js#L231

This method uses a binary NAF method of multiplication, which leaks the bit-length of the scalar via timing, among other info. This is directly explitable by the above attack.

https://github.com/kjur/jsrsasign/blob/master/ext/ec.js#L185

@snoopysecurity
Copy link

I see this issue still haven't been triaged. Maintainers, any plans of fixing this issue? @J08nY do you have any plans on opening a PR here like you did for the other libraries you disclosed the vulnerability to? That might help push this forward if you are not too busy :)

@kjur
Copy link
Owner

kjur commented Mar 31, 2020

Sorry to be late response. It's fixed in release 8.0.13 today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants