Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unlisten to Display.onOrientationDidChange #4

Closed
albertwchang opened this issue Jul 17, 2015 · 4 comments
Closed

Unlisten to Display.onOrientationDidChange #4

albertwchang opened this issue Jul 17, 2015 · 4 comments

Comments

@albertwchang
Copy link
Contributor

Does this method get unregistered after the underlying component gets unmounted? If not, i'm wondering how one can do so (unregister this listener).
@kkjdaniel
Copy link
Owner

Will be adding this feature in shortly - expect it within the next couple of days.

@albertwchang
Copy link
Contributor Author

@kkjdaniel: I just tried npm install react-native-device-display@latest roughly 3 times, and never did the downloads reflect the latest update (e.g. returning the subscriber from RCTEventEmitter.addListener()). Just an fyi...

@kkjdaniel
Copy link
Owner

Sorry, I have only now pushed the latest package to NPM.

@albertwchang
Copy link
Contributor Author

no problemo. Sweet! thanks for the update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@albertwchang @kkjdaniel