Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: kkrt-labs/kakarot
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.8.2
Choose a base ref
...
head repository: kkrt-labs/kakarot
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.8.3
Choose a head ref
  • 6 commits
  • 17 files changed
  • 5 contributors

Commits on Jun 12, 2024

  1. fix unsound get_felt_bitlength (#1199)

    <!--- Please provide a general summary of your changes in the title
    above -->
    
    <!-- Give an estimate of the time you spent on this PR in terms of work
    days.
    Did you spend 0.5 days on this PR or rather 2 days?  -->
    
    Time spent on this PR:
    1h
    
    ## Pull request type
    
    <!-- Please try to limit your pull request to one type,
    submit multiple pull requests if needed. -->
    
    Please check the type of change your PR introduces:
    
    - [ ] Bugfix
    - [ ] Feature
    - [ ] Code style update (formatting, renaming)
    - [ ] Refactoring (no functional changes, no api changes)
    - [ ] Build related changes
    - [ ] Documentation content changes
    - [ ] Other (please describe):
    
    ## What is the current behavior?
    
    <!-- Please describe the current behavior that you are modifying,
    or link to a relevant issue. -->
    
    Resolves #<Issue number>
    
    ## What is the new behavior?
    
    <!-- Please describe the behavior or changes that are being added by
    this PR. -->
    
    - Assumes u128 in get_felt_bitlength to get rid of bitwises
    - add a range check on the prover given value. The prover may still find
    an offset that gives the correct bit value starting from the beginning
    of the dw array (if the correct value is present anywhere in the
    bytecode or memory of the program), but the function would an offset
    which would be wrong. bit_length must be constrained to be in [0,128]
    - Optimize slightly lookup in pow2.
    - Optimize slightly get_u256 bitlength logic.
    - Improve function documentation
    
    <!-- Reviewable:start -->
    - - -
    This change is [<img src="https://reviewable.io/review_button.svg"
    height="34" align="absmiddle"
    alt="Reviewable"/>](https://reviewable.io/reviews/kkrt-labs/kakarot/1199)
    <!-- Reviewable:end -->
    feltroidprime committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    adaca06 View commit details
    Browse the repository at this point in the history
  2. Add workflow to PR kakarot RPC on release (#1200)

    Note: I've had to create a Personal Access Token with write access to
    the RPC repo for this to work
    
    See resulting PR in RPC
    kkrt-labs/kakarot-rpc#1181 (got modifying the
    `on` condition to trigger the workflow, see also
    https://github.com/kkrt-labs/kakarot/actions/runs/9481929981/job/26125717974
    
    With the release condition activated, see
    https://github.com/ClementWalter/kakarot/actions/runs/9483859582/job/26131981795
    
    <!-- Reviewable:start -->
    - - -
    This change is [<img src="https://reviewable.io/review_button.svg"
    height="34" align="absmiddle"
    alt="Reviewable"/>](https://reviewable.io/reviews/kkrt-labs/kakarot/1200)
    <!-- Reviewable:end -->
    ClementWalter committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    87d4ce5 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2024

  1. Adding Unit tests for set_nonce and set_implementation (#1202)

    <!--- Please provide a general summary of your changes in the title
    above -->
    
    <!-- Give an estimate of the time you spent on this PR in terms of work
    days.
    Did you spend 0.5 days on this PR or rather 2 days?  -->
    
    Time spent on this PR: 1 day
    
    ## Pull request type
    
    <!-- Please try to limit your pull request to one type,
    submit multiple pull requests if needed. -->
    
    Please check the type of change your PR introduces:
    
    - [ ] Bugfix
    - [X] Feature
    - [ ] Code style update (formatting, renaming)
    - [ ] Refactoring (no functional changes, no api changes)
    - [ ] Build related changes
    - [ ] Documentation content changes
    - [ ] Other (please describe):
    
    ## What is the current behavior?
    
    <!-- Please describe the current behavior that you are modifying,
    or link to a relevant issue. -->
    
    Resolves #1186 
    
    ## What is the new behavior?
    
    <!-- Please describe the behavior or changes that are being added by
    this PR. -->
    
    -New unit test for set_nonce
    -New unit test for set_implementation
    -New cairo func called test__set_nonce
    -New cairo func called test__set_implementation
    
    <!-- Reviewable:start -->
    - - -
    This change is [<img src="https://reviewable.io/review_button.svg"
    height="34" align="absmiddle"
    alt="Reviewable"/>](https://reviewable.io/reviews/kkrt-labs/kakarot/1202)
    <!-- Reviewable:end -->
    fabrobles92 committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    774e7ff View commit details
    Browse the repository at this point in the history
  2. feat: add upgrade account entrypoint to Kakarot (#1207)

    <!--- Please provide a general summary of your changes in the title
    above -->
    
    <!-- Give an estimate of the time you spent on this PR in terms of work
    days.
    Did you spend 0.5 days on this PR or rather 2 days?  -->
    
    Time spent on this PR:
    
    ## Pull request type
    
    <!-- Please try to limit your pull request to one type,
    submit multiple pull requests if needed. -->
    
    Please check the type of change your PR introduces:
    
    - [ ] Bugfix
    - [ ] Feature
    - [ ] Code style update (formatting, renaming)
    - [ ] Refactoring (no functional changes, no api changes)
    - [ ] Build related changes
    - [ ] Documentation content changes
    - [ ] Other (please describe):
    
    ## What is the current behavior?
    
    <!-- Please describe the current behavior that you are modifying,
    or link to a relevant issue. -->
    
    Resolves #<Issue number>
    
    ## What is the new behavior?
    
    <!-- Please describe the behavior or changes that are being added by
    this PR. -->
    
    -
    -
    -
    
    <!-- Reviewable:start -->
    - - -
    This change is [<img src="https://reviewable.io/review_button.svg"
    height="34" align="absmiddle"
    alt="Reviewable"/>](https://reviewable.io/reviews/kkrt-labs/kakarot/1207)
    <!-- Reviewable:end -->
    enitrat committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    e5aa4be View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2024

  1. fix deploy (#1206)

    <!--- Please provide a general summary of your changes in the title
    above -->
    
    <!-- Give an estimate of the time you spent on this PR in terms of work
    days.
    Did you spend 0.5 days on this PR or rather 2 days?  -->
    
    Time spent on this PR: 0.1 day
    
    ## Pull request type
    
    <!-- Please try to limit your pull request to one type,
    submit multiple pull requests if needed. -->
    
    Please check the type of change your PR introduces:
    
    - [x] Bugfix
    - [ ] Feature
    - [ ] Code style update (formatting, renaming)
    - [ ] Refactoring (no functional changes, no api changes)
    - [ ] Build related changes
    - [ ] Documentation content changes
    - [ ] Other (please describe):
    
    ## What is the new behavior?
    Fixes deploy script for staging.
    <!-- Please describe the current behavior that you are modifying,
    or link to a relevant issue. -->
    
    <!-- Reviewable:start -->
    - - -
    This change is [<img src="https://reviewable.io/review_button.svg"
    height="34" align="absmiddle"
    alt="Reviewable"/>](https://reviewable.io/reviews/kkrt-labs/kakarot/1206)
    <!-- Reviewable:end -->
    greged93 committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    2d98898 View commit details
    Browse the repository at this point in the history
  2. fix: add cairo 1 contract in deployer (#1208)

    <!--- Please provide a general summary of your changes in the title
    above -->
    
    <!-- Give an estimate of the time you spent on this PR in terms of work
    days.
    Did you spend 0.5 days on this PR or rather 2 days?  -->
    
    Time spent on this PR: 0.1 day
    
    ## Pull request type
    
    <!-- Please try to limit your pull request to one type,
    submit multiple pull requests if needed. -->
    
    Please check the type of change your PR introduces:
    
    - [x] Bugfix
    - [ ] Feature
    - [ ] Code style update (formatting, renaming)
    - [ ] Refactoring (no functional changes, no api changes)
    - [ ] Build related changes
    - [ ] Documentation content changes
    - [ ] Other (please describe):
     to a relevant issue. -->
    
    Resolves #NA
    
    ## What is the new behavior?
    Add the cairo 1 contracts in the deployer (otherwise we cannot use the
    deployer in a docker compose with Katana).
    
    <!-- Reviewable:start -->
    - - -
    This change is [<img src="https://reviewable.io/review_button.svg"
    height="34" align="absmiddle"
    alt="Reviewable"/>](https://reviewable.io/reviews/kkrt-labs/kakarot/1208)
    <!-- Reviewable:end -->
    greged93 committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    ca7badc View commit details
    Browse the repository at this point in the history
Loading