Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Great template #10

Open
imsganesh opened this issue Mar 21, 2014 · 2 comments
Open

Great template #10

imsganesh opened this issue Mar 21, 2014 · 2 comments

Comments

@imsganesh
Copy link

I really like is template, especially the modular folder structure. Any chance you could add Heroku deployment task/scripts to the template? or give some directions. I tried to add the Heroku configuration, but it doesn't seem to work when I access the app hosted on heroku.

Thanks!

@joakimbeng
Copy link
Member

Hi @imsganesh, actually I don't think that such configuration belongs in this generator. It's supposed to be environment independent.

How is it not working? How's your procfile looking?
I think it should contain:

web: node src/index.js

Also make sure you have run grunt dist and committed the ./dist folder to your git repository before pushing to Heroku.

@imsganesh
Copy link
Author

Thanks for the reply, Joakim. Yes, I did have that in my Procfile. for some reason it failed when I accessed the site. I didn't have enough time to dig into the error due to work presssure. I'll try again once I get some time.

I was basically referring to a similar generator https://github.com/darryl-snow/generator-angular-express-stylus for deployment purposes. the deployment command just works without any tweaking.
Also, I like the way how the dist folder structure after the build. we have one lib folder for the server code and one public folder for the client. it looks clean. this is not a request for change. just wanted to pick your brain on the dist folder structure.

Thanks a lot, Ganesh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants