Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register new Arbitrables with the Arbitrator for indexing on the fly with no subgraph change or redeploy #1470

Open
jaybuidl opened this issue Jan 31, 2024 · 0 comments
Assignees
Labels
Compatibility: ABI change 🗯 Smart contract ABI is changing. Package: Contracts Court smart contracts Package: Subgraph Court subgraph Package: Web Court web frontend

Comments

@jaybuidl
Copy link
Member

jaybuidl commented Jan 31, 2024

Rationale

We cannot start indexing Arbitrable contracts newly deployed in the wild before they have interacted with a known already indexed contract. We also cannot modify and redeploy the subgraph every time that a new Arbitrable contract has been deployed. So far we have used the DisputeTemplateRegistry as a fixed contract to partially address this indexing challenge: it covers the need to index dispute templates and mappings, but not DisputeRequest events.

Registering all Arbitrables first with the Arbitrator allows a subgraph to start indexing future events from the Arbitrables. Consequently the DisputeTemplateRegistry could be removed (inlined inside arbitrables or as a library).

In a crosschain context, the Arbitrator is the ForeignGateway.

Resolves #1316 #1317

@jaybuidl jaybuidl changed the title Register new Arbitrables with the Arbitrator to get indexed on the fly with no subgraph change or redeploy Register new Arbitrables with the Arbitrator for indexing on the fly with no subgraph change or redeploy Jan 31, 2024
@jaybuidl jaybuidl added Compatibility: ABI change 🗯 Smart contract ABI is changing. Package: Web Court web frontend Package: Contracts Court smart contracts Package: Subgraph Court subgraph labels Jan 31, 2024
@jaybuidl jaybuidl self-assigned this Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Compatibility: ABI change 🗯 Smart contract ABI is changing. Package: Contracts Court smart contracts Package: Subgraph Court subgraph Package: Web Court web frontend
Projects
None yet
Development

No branches or pull requests

1 participant