Can we combine ko.local and --bare ?

[eddycharly]

Is this possible to combine ko.local with --bare options to produce an image in the form ko.local/something ?
It looks like setting KO_DOCKER_REPO=ko.local/something produces an image with the name ko.local.

[imjasonh]

v0.12 fixed a bug with KO_DOCKER_REPO=ko.local/foo which might be what you're describing.

That should work and if not it's a bug we should fix

[eddycharly]

Looks like it’s a bug, I’m using 0.12.
I’ll try again later today to be sure.

[imjasonh]

I've confirmed this behavior, and I believe it's a bug:

$ ko version
0.12.0
$ KO_DOCKER_REPO=ko.local/test ko build --bare
...
ko.local:b892c8419de3e2b9729a50707a75ba8643fe56c704bfe5625dcc7c19f1741c5f

This should be ko.local/test:b89...

[eddycharly]

Thanks for confirming the bug @imjasonh

[eddycharly]

@imjasonh can this come from this

ko/pkg/commands/options/publish.go

Line 37 in 516cae1

LocalDomain string

never being assigned ?

[imjasonh]

LocalDomain is used by clients that use ko as a library (e.g., Skaffold), so it's not set by ko itself, and defaults to ko.local.

Support for KO_DOCKER_REPO=ko.local/foo is actually very new, prior to #796 we didn't support it at all -- only KO_DOCKER_REPO=ko.local exactly.

There seem to be a few lingering places where code assumes local images will be pushed to exactly ko.local:

ko/pkg/commands/config.go

Line 62 in 9a1eae8

if ref.Context().RegistryStr() == publish.LocalDomain {

(for local base images, unrelated to this issue)

It looks like the issue is here:

ko/pkg/publish/daemon.go

Line 72 in 9a1eae8

base: LocalDomain,

NewDaemon is called when strings.HasPrefix(KO_DOCKER_REPO, LocalDomain), here:

ko/pkg/commands/resolver.go

Line 175 in 9a1eae8

return publish.NewDaemon(namer, po.Tags,

...but then NewDaemon just sets LocalDomain only, without any local repo component.

I've got a fix I'll send out shortly.

[eddycharly]

Thanks for looking at it @imjasonh !
This line looked suspicious

ko/pkg/commands/resolver.go

Line 177 in 9a1eae8

publish.WithLocalDomain(po.LocalDomain),

and made me suspect LocalDomain was guilty.