Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch random items to feed - shuffle #1176

Closed
yangwao opened this issue Nov 16, 2021 · 7 comments
Closed

Fetch random items to feed - shuffle #1176

yangwao opened this issue Nov 16, 2021 · 7 comments
Labels
$$ ~51-150usd entropy p3 non-core, affecting less than 40%

Comments

@yangwao
Copy link
Member

yangwao commented Nov 16, 2021

Now magic wand shuffles between pages which is good and we would add functionality that it would shuffle from the whole set of NFTs new feed.
It could be expanded with an existing magic wand

Implement it for

  • gallery feed
  • collection detail
  • collections
  • profile
@yangwao yangwao added $$ ~51-150usd p3 non-core, affecting less than 40% entropy labels Nov 16, 2021
@prachi00
Copy link
Member

@yangwao Can you explain more? You mean now the magic random button should shuffle nfts by staying on page 1 only?

@yangwao
Copy link
Member Author

yangwao commented Nov 18, 2021

@yangwao Can you explain more? You mean now the magic random button should shuffle nfts by staying on page 1 only?

It should fetch random NFTs, not just pages. that mean to have more variance.
let me draft on explainer.

when I click on random button now, I see NFTs in fixed range of 12, so I land either on [24-36] [36-48] [48-60]

but with shuffle I would like to have NFTs on page fetched from page 25, page 46, page 56, and so on.
So you can randomize page and order of NFTs and then assemble whole new "page"

Probably we can think of putting the address of that NFTs into address bar so that your shuffle roll is shareable

@prachi00
Copy link
Member

@yangwao by new page, you mean user should go the nft detail route? /rmrk/detail this one, with the random nft ?
Also, where should the shuffle button show up? near the magic wand?

@yangwao
Copy link
Member Author

yangwao commented Nov 22, 2021

@yangwao by new page, you mean user should go the nft detail route? /rmrk/detail this one, with the random nft ?

You should assembly new NFTs. Right now when you are doing pagination, NFTs are shown in order how they've been minted.
We are working on shuffle, so order should be randomized no matter in what time order they've been minted or listed.

Also, where should the shuffle button show up? near the magic wand?
Yes, on gallery feed next to the magic wand.

Re item detail
Oh, actually that's a good idea as well.
Let's add a random button to the item detail if possible.
On that let's continue #1252

@prachi00
Copy link
Member

prachi00 commented Nov 22, 2021

@yangwao also I have two more doubts:

  1. How are we suppose to fetch random nfts from different pages because we have pagination, so we don't really have all the data initially?
  2. when we do shuffle, like suppose in gallery, what happens to the pagination in gallery? is it hidden?

@prachi00
Copy link
Member

@yangwao do let me know more on this, thank you

@yangwao
Copy link
Member Author

yangwao commented Nov 24, 2021

@yangwao also I have two more doubts:

  1. How are we suppose to fetch random nfts from different pages because we have pagination, so we don't really have all the data initially?

Good question! Probably it will be heavy, let's summon @vikiival if have idea how to do it efficiently.

  1. when we do shuffle, like suppose in gallery, what happens to the pagination in gallery? is it hidden?

Yeah, pagination will be effectively gone because pagination from my point is something comparing to known index/position where in shuffle you are creating new "index" on your own.

@JustLuuuu JustLuuuu closed this as not planned Won't fix, can't repro, duplicate, stale Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
$$ ~51-150usd entropy p3 non-core, affecting less than 40%
Projects
None yet
Development

No branches or pull requests

3 participants