Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Statemine collection not loading #6618

Closed
JustLuuuu opened this issue Aug 8, 2023 · 7 comments · Fixed by #7639
Closed

Statemine collection not loading #6618

JustLuuuu opened this issue Aug 8, 2023 · 7 comments · Fixed by #7639
Labels
A-statemine-ahk related for statemine common chain, under new name Asset Hub Kusama bug Something isn't working

Comments

@JustLuuuu
Copy link
Member

This collection on statemine is not loading properly: production and canary too

Screenshot 2023-08-08 at 16 43 03
@JustLuuuu JustLuuuu added bug Something isn't working A-statemine-ahk related for statemine common chain, under new name Asset Hub Kusama labels Aug 8, 2023
@preschian
Copy link
Member

the creator put metadata and image on s3 bucket, not ipfs

{
  "name": "ASM Brains #5413",
  "description": "Token 5413 minted By Altered_State_Machine",
  "image": "https://polkadot-data.s3.us-east-2.amazonaws.com/metadata/nfts-88/nfts-88_item-5413-img.jpg",
  "license": "License name",
  "licenseUri": "https://license.com",
  "tags": [
    "Art",
    "Ethereum"
  ],
  "attributes": [
    {
      "label": "GENERATION",
      "value": "Genesis"
    },
    {
      "label": "COLORS",
      "value": "Blue Orange Pale Pink"
    }
  ]
}

@preschian
Copy link
Member

Not sure if we should show the nft or not. metadata for this item https://kodadot.xyz/stmn/gallery/89-56217, is not a valid JSON file https://polkadot-data.s3.us-east-2.amazonaws.com/metadata/nfts-89/nfts-89_item-56217-meta.json

just for comparison, on the singular only shows if the item on ipfs https://singular.app/space/DSJV1MxfKcv1cXy25cWLYzsYZ9q1zsGqWj49o1vPAtemMeM/nfts/owned?network=statemine

@preschian
Copy link
Member

steps to support non-ipfs format:

  1. need to extend image workers. WIP: feat: support custom url on image workers workers#136
  2. adjust our UI to hit a new endpoint if metadata/image/mediaUri is from a custom URL
  3. adjust our UI to validate metadata as a json

seems like the creator of nft can update their nft metadata after minting on AssetHub. can someone confirm? I see there is setMetadata() from extrinsic. if that is the case, we can extend no.3 to show a popup to the user in gallery detail page and tell them that something like "metadata invalid". It would be good if the creator could update their nft metadata directly in our UI

image

@roiLeo
Copy link
Contributor

roiLeo commented Oct 13, 2023

@roiLeo roiLeo closed this as completed Oct 13, 2023
@preschian
Copy link
Member

@roiLeo why close the issue? Please see the console error. And try to visit one of the items. some features are not working, such as download and details tab

@roiLeo
Copy link
Contributor

roiLeo commented Oct 14, 2023

@roiLeo why close the issue? Please see the console error. And try to visit one of the items. some features are not working, such as download and details tab

Collection loads well on my side check screenshots

@preschian
Copy link
Member

the error was not only load the image in the collection page, the asset/metadata url was on non ipfs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-statemine-ahk related for statemine common chain, under new name Asset Hub Kusama bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants