Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: container size to tailwind #9245

Open
roiLeo opened this issue Feb 2, 2024 · 7 comments
Open

refactor: container size to tailwind #9245

roiLeo opened this issue Feb 2, 2024 · 7 comments
Labels
A-refactoring Refactoring stuff, make code more readable, mitigating tech debt css good first issue as new commer, something you could start with p3 non-core, affecting less than 40%

Comments

@roiLeo
Copy link
Contributor

roiLeo commented Feb 2, 2024

Replace container is-* to tailwind equivalent

@roiLeo roiLeo added good first issue as new commer, something you could start with p3 non-core, affecting less than 40% A-refactoring Refactoring stuff, make code more readable, mitigating tech debt css labels Feb 2, 2024
@pbkompasz
Copy link
Contributor

👋

@kodabot
Copy link
Collaborator

kodabot commented Feb 3, 2024

ASSIGNED - @pbkompasz 🔒 LOCKED -> Sunday, February 4th 2024, 23:20:22 UTC -> 36 hours

@pbkompasz
Copy link
Contributor

@roiLeo Tailwind's container sets the max-width of the container to a given breakpoint e.g. anything width above 1536px, the max-width stays 1536px + the .is-fluid class adds 2.5rem padding on each side.
Between breakpoints this happens:
Screenshot from 2024-02-04 13-28-32
Screenshot from 2024-02-04 13-28-16
I could change it instead to w-full px-[2.5rem] and not use the container class.

@roiLeo
Copy link
Contributor Author

roiLeo commented Feb 4, 2024

@roiLeo Tailwind's container sets the max-width of the container to a given breakpoint e.g. anything width above 1536px, the max-width stays 1536px + the .is-fluid class adds 2.5rem padding on each side.
Between breakpoints this happens:
Screenshot from 2024-02-04 13-28-32
Screenshot from 2024-02-04 13-28-16
I could change it instead to w-full px-[2.5rem] and not use the container class.

Let's try!

@kodabot
Copy link
Collaborator

kodabot commented Feb 23, 2024

ASSIGNMENT EXPIRED - @pbkompasz has been unassigned.

@zeshhaan
Copy link
Contributor

Can share bit more context here as i look forward working on it again and make sure we are on the same page?

Replace container is-* to tailwind equivalent

Here is what my thought process was while taking this issue:
remove css variable dependancy, and use tailwind class.

Looking at the comment by @Jarsen136 at #9870 (comment) did you mean to use a wrapper aka container width size instead of adjusting with paddings?

@Jarsen136
Copy link
Contributor

Can share bit more context here as i look forward working on it again and make sure we are on the same page?

Replace container is-* to tailwind equivalent

Here is what my thought process was while taking this issue: remove css variable dependancy, and use tailwind class.

Looking at the comment by @Jarsen136 at #9870 (comment) did you mean to use a wrapper aka container width size instead of adjusting with paddings?

replace class name container is-x with class name from tailwind. The important point is that we should keep the same UI as before.

https://tailwindcss.com/docs/container

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-refactoring Refactoring stuff, make code more readable, mitigating tech debt css good first issue as new commer, something you could start with p3 non-core, affecting less than 40%
Projects
None yet
5 participants