Skip to content

Latest commit

 

History

History
31 lines (21 loc) · 2.38 KB

contributing.md

File metadata and controls

31 lines (21 loc) · 2.38 KB

Welcome to portr contributing guide

In this guide you will get an overview of the contribution workflow from opening an issue, creating a PR, reviewing, and merging the PR.

Issues

Create a new issue

Pick up an issue to solve

  • Scan through our existing issues to find one that interests you.
  • The 👋 good first issue is a good place to start exploring issues that are well-groomed for newcomers.
  • Do not hesitate to ask for more details or clarifying questions on the issue!
  • Communicate on the issue you are intended to pick up before starting working on it.
  • Every issue that gets picked up will have an expected timeline for the implementation, the issue may be reassigned after the expected timeline. Please be responsible and proactive on the communication 🙇‍♂️

Pull requests

When you're finished with the changes, create a pull request, or a series of pull requests if necessary.

Contributing to another codebase is not as simple as code changes, it is also about contributing influence to the design. Therefore, we kindly ask you that:

  • Please acknowledge that no pull request is guaranteed to be merged.
  • Please always do a self-review before requesting reviews from others.
  • Please expect code review to be strict and may have multiple rounds.
  • Please make self-contained incremental changes, pull requests with huge diff may be rejected for review.
  • Please use English in code comments and docstring.
  • Please do not force push unless absolutely necessary. Force pushes make review much harder in multiple rounds, and we use Squash and merge so you don't need to worry about messy commits and just focus on the changes.