Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(textarea): canGrow properties initialization (#DS-2452) #38

Merged
merged 1 commit into from
May 21, 2024

Conversation

NikGurev
Copy link
Contributor

Summary

Updated initialization of properties responsible for height calculation. It's specific case: in modal, container attached in afterViewInit, so these properites won't be initialized correctly, so in this PR initialization deferred.

List of notable changes:

  • updated nitialization of properties responsible for height calculation

P.S. there is another idea to replace KBQ_PARENT_ANIMATION_COMPONENT with observable and use factory:

{
    provide: KBQ_PARENT_ANIMATION_COMPONENT,
    deps: [KbqTabGroup],
    useFactory: (tabGroup: KbqTabGroup) => tabGroup.animationDone
}

And for modal use similar subject

@NikGurev NikGurev requested a review from lskramarov May 20, 2024 09:17
@NikGurev NikGurev self-assigned this May 20, 2024
Copy link

Visit the preview URL for this PR (updated for commit ac6bb69):

https://koobiq-next--prs-38-62mxs7bo.web.app

(expires Sat, 25 May 2024 09:22:44 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c

@lskramarov lskramarov merged commit 7a19c73 into main May 21, 2024
5 checks passed
@lskramarov lskramarov deleted the bugfix/DS-2452 branch May 21, 2024 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants