Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map paired-end reads that overlap each other’s 5' ends #320

Open
marcelm opened this issue Jun 29, 2023 · 2 comments
Open

Map paired-end reads that overlap each other’s 5' ends #320

marcelm opened this issue Jun 29, 2023 · 2 comments

Comments

@marcelm
Copy link
Collaborator

marcelm commented Jun 29, 2023

As has come up in #317 reported by @y9c, when mapping paired-end reads, we should allow for the case that reads overlap in this way:

R1         -------->
R2   <--------

Strobealign currently allows these two situations:

  1. R1 is forward, R2 is reverse, and the leftmost mapped base of R1 is less than the leftmost mapped base of R2 (R1---> <---R2)
  2. R2 is forward, R1 is reverse and the leftmost mapped base of R2 is less than the leftmost mapped base of R1 (R2---> <---R1)

(#317 changes the above to "... is less than or equal to ...")

It appears to me that to, for the first situation, we just need to change this to "... leftmost mapped base of R1 is less than the rightmost mapped base of R2" and similar for the second situation.

@marcelm
Copy link
Collaborator Author

marcelm commented Jun 29, 2023

When judging whether seeds (not reads) are proper pairs, the above doesn’t quite work because we don’t know what the leftmost or rightmost mapped bases are going to be, mainly because we don’t know how many bases are going to be soft clipped on either side.

In a situation like this (==== show seed locations), the seeds would not overlap at all, but the reads could:

R1                      -------------------->
                                   ====
R2     <------------------------
            ====

To ensure we don’t mistakenly rule out a pair, we can assume that the alignment extends ungapped to either end of the read. (I believe this is already done for the 5' end at the moment.)

@ksahlin
Copy link
Owner

ksahlin commented Jun 29, 2023

I agree your proposed solutions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants