Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[e2e tests] Add CNIManifestPath and namespaces as inputs to ClusterctlUpgradeSpec #6465

Closed
mboukhalfa opened this issue Apr 29, 2022 · 3 comments · Fixed by #6636
Closed
Labels
area/testing Issues or PRs related to testing kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@mboukhalfa
Copy link
Member

User Story

In order to reuse ClusterctlUpgradeSpec with CAPM3 we might need the possibility to set clusters namespace and CNIManifestPath in ClusterctlUpgradeSpecInput.

Detailed Description

CAPM3 provider requires BMH CRs available in the same namespace before creating the cluster. However, since the ClusterctlUpgradeSpec creates dynamic and random namespaces without giving any option to reuse an existing namespace CAPM3 cannot set the those BMH before creating the cluster.

Would be great for the test portability if we can have the possibility to input the namespaces for both management and workload clusters, and setting CNIManifestPath.

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 29, 2022
@fabriziopandini
Copy link
Member

/area testing
/milestone v1.2

@k8s-ci-robot k8s-ci-robot added this to the v1.2 milestone May 8, 2022
@k8s-ci-robot k8s-ci-robot added the area/testing Issues or PRs related to testing label May 8, 2022
@fabriziopandini
Copy link
Member

fabriziopandini commented Jun 1, 2022

CAPM3 provider requires BMH CRs available in the same namespace before creating the cluster. However, since the ClusterctlUpgradeSpec creates dynamic and random namespaces without giving any option to reuse an existing namespace CAPM3 cannot set the those BMH before creating the cluster.

I would prefer to keep the current behavior of the test being created in a random namespace because this helps in running different tests (including variations of the same test) in isolation.

I would suggest a different approach instead. Why not explore/extend the usage of hooks allowing you to add your custom resources? Please note that this approach is already used by other providers and we already have PreInit, PreUpgrade, PostUpgrade

... and setting CNIManifestPath.

This is already possible using the CNI variable

@fabriziopandini fabriziopandini added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Jul 29, 2022
@fabriziopandini fabriziopandini removed this from the v1.2 milestone Jul 29, 2022
@fabriziopandini fabriziopandini removed the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Jul 29, 2022
@fabriziopandini
Copy link
Member

/triage accepted

@k8s-ci-robot k8s-ci-robot added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Issues or PRs related to testing kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants