Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conformance: test gateway referencing an unexisting tls secret #1318

Closed
mlavacca opened this issue Aug 12, 2022 · 1 comment · Fixed by #1334
Closed

conformance: test gateway referencing an unexisting tls secret #1318

mlavacca opened this issue Aug 12, 2022 · 1 comment · Fixed by #1334
Assignees
@mlavacca
Labels
area/conformance help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Milestone
v0.6.0

Comments

@mlavacca
Copy link
Member

What would you like to be added:

A new conformance test case testing the presence of the status ResolvedRefs condition failed with the reason InvalidCertificateRef should be added to the conformance test suite.

To do so, the test case should create a gateway that references a non-existing TLS secret and check the failed ResolvedRefs condition is added to the corresponding listener status with the reason InvalidCertificateRef.

Why this is needed:

This is needed to ensure that when the referenced secret does not exist, the listener status is set accordingly.
@mlavacca mlavacca added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 12, 2022
@shaneutt shaneutt added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. area/conformance labels Aug 12, 2022
@shaneutt shaneutt added this to the v0.6.0 milestone Aug 12, 2022
@mlavacca
Copy link
Member Author

/assign

@mlavacca mlavacca mentioned this issue Aug 16, 2022
Merged
@mlavacca mlavacca mentioned this issue Aug 23, 2022
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mlavacca mlavacca

Labels
area/conformance help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging a pull request may close this issue.

conformance: listener references invalid secret mlavacca/gateway-api
2 participants
@shaneutt @mlavacca