Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CEL: Need Test Coverage against Multiple Kubernetes Versions #3206

Closed
robscott opened this issue Jul 20, 2024 · 0 comments · Fixed by #3316
Closed

CEL: Need Test Coverage against Multiple Kubernetes Versions #3206

robscott opened this issue Jul 20, 2024 · 0 comments · Fixed by #3316
Assignees
Milestone

Comments

@robscott
Copy link
Member

What happened:
In #3205 we were fortunate to be running an old version of Kubernetes that caught a CEL cost estimation error described in kubernetes/kubernetes#126239. Since we claim support for 5 trailing versions of Kubernetes, we need to have test coverage that ensures our CRDs are valid across that range, at minimum testing the newest and oldest version in that range.

What you expected to happen:
Have proper test coverage across the Kubernetes versions we support.

Anything else we need to know?:
@howardjohn is working on istio/api#3275 for Istio, we likely want to copy that pattern for Gateway API. Alternatively we could use different versions of https://github.com/kubernetes-sigs/kubectl-validate, or continue spinning up kind clusters and just have different CI jobs for different k8s versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants