From 50159d47c2f47244afef4cfcde6dd69ead2a9d2f Mon Sep 17 00:00:00 2001 From: chansuke Date: Tue, 17 Oct 2023 23:55:04 +0900 Subject: [PATCH] Add negative case for testing `keyValuesFromLine` --- api/kv/kv_test.go | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/api/kv/kv_test.go b/api/kv/kv_test.go index 143e664e50..529cdb0385 100644 --- a/api/kv/kv_test.go +++ b/api/kv/kv_test.go @@ -70,14 +70,19 @@ func TestKeyValuesFromLines(t *testing.T) { }, expectedErr: false, }, - // TODO: add negative testcases + { + desc: "invalid UTF-8 content", + content: "Invalid UTF8 Content: \x80\x81", + expectedPairs: nil, + expectedErr: true, + }, } kvl := makeKvLoader(filesys.MakeFsInMemory()) for _, test := range tests { pairs, err := kvl.keyValuesFromLines([]byte(test.content)) if test.expectedErr && err == nil { - t.Fatalf("%s should not return error", test.desc) + t.Fatalf("%s should return error", test.desc) } if !reflect.DeepEqual(pairs, test.expectedPairs) { t.Errorf("%s should succeed, got:%v exptected:%v", test.desc, pairs, test.expectedPairs)