-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable s390x to test containers #318
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@mkumatag would you like help to review too. |
/assign @mkumatag |
guestbook/php-redis/Dockerfile
Outdated
@@ -14,6 +14,9 @@ | |||
|
|||
FROM php:5-apache | |||
|
|||
COPY fixup-apt-list.sh / |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand we don't have security updates for jessie release, but I'm wondering whether we can update to the latest version which has stretch as base image which does work without any of these crazy patches!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the image can work well without these crazy patchers.
remove the update command.
test AMD64:
root@zkubetest:~# docker run gcr.io/google-samples/gb-frontend:v6
AH00558: apache2: Could not reliably determine the server's fully qualified domain name, using 172.17.0.2. Set the 'ServerName' directive globally to suppress this message
AH00558: apache2: Could not reliably determine the server's fully qualified domain name, using 172.17.0.2. Set the 'ServerName' directive globally to suppress this message
[Mon May 13 15:20:09.977625 2019] [mpm_prefork:notice] [pid 1] AH00163: Apache/2.4.25 (Debian) PHP/5.6.40 configured -- resuming normal operations
[Mon May 13 15:20:09.977691 2019] [core:notice] [pid 1] AH00094: Command line: 'apache2 -D FOREGROUND'
^C[Mon May 13 15:20:12.871811 2019] [mpm_prefork:notice] [pid 1] AH00169: caught SIGTERM, shutting down
root@zkubetest:~#
test s390x:
root@d230718d690f:/home/liudali# docker run gcr.io/google-samples/gb-frontend-s390x:v6
AH00557: apache2: apr_sockaddr_info_get() failed for c3a219b07c49
AH00558: apache2: Could not reliably determine the server's fully qualified domain name, using 127.0.0.1. Set the 'ServerName' directive globally to suppress this message
AH00557: apache2: apr_sockaddr_info_get() failed for c3a219b07c49
AH00558: apache2: Could not reliably determine the server's fully qualified domain name, using 127.0.0.1. Set the 'ServerName' directive globally to suppress this message
[Mon May 13 15:15:24.111847 2019] [mpm_prefork:notice] [pid 1] AH00163: Apache/2.4.10 (Debian) PHP/5.6.32 configured -- resuming normal operations
[Mon May 13 15:15:24.111879 2019] [core:notice] [pid 1] AH00094: Command line: 'apache2 -D FOREGROUND'
^C[Mon May 13 15:15:30.170413 2019] [mpm_prefork:notice] [pid 1] AH00169: caught SIGTERM, shutting down
root@d230718d690f:/home/liudali#
@mkumatag please review again.
/lgtm |
/assign @idvoretskyi |
PR is ready for approve and merge |
@idvoretskyi @sebgoa would you like help to review this PR, this one is helpful to run conformance test base on kubernetes cluster which one have Z worker nodes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: idvoretskyi, liudalibj, mkumatag The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@liudalibj we need to ask someone who has access to gcr repo to push the images as well.! |
@idvoretskyi thank you for approve and merge this PR.
I would like to provide any help on this and I have verified that these images can be built out on Ubuntu 18.04.2 and these s390x images works as expected on Z platform. |
Hmm I actually do not have push access to that repo. @ixdy, do you have access? |
I think you need to reach out to @ahmetb. |
@ixdy I might give you access for this, I am no longer the maintainer of the gcr.io/google-samples. @dansanche if you have time, do you mind running the build/push command on the examples/guestbook sample? |
thanks for your help @ixdy @ahmetb @listx @dansanche @dims |
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
Conformance testing on s390x kubernetes/kubernetes#67721
Which issue(s) this PR fixes:
Fixes #
conformance failures on s390x
Special notes for your reviewer:
This PR is same as kubernetes/kubernetes#75344,
build out images: google-samples/gb-frontend-s390x:v6 and google-samples/gb-redisslave-s390x:v3