Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Redis slave image to new location. #327

Merged
merged 2 commits into from
Jul 2, 2019

Conversation

nrdlngr
Copy link
Contributor

@nrdlngr nrdlngr commented Jun 27, 2019

Resurrecting #319
Fixes #321

@k8s-ci-robot
Copy link
Contributor

Welcome @nrdlngr!

It looks like this is your first PR to kubernetes/examples 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/examples has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 27, 2019
@nrdlngr
Copy link
Contributor Author

nrdlngr commented Jun 27, 2019

/re-test

@nrdlngr
Copy link
Contributor Author

nrdlngr commented Jun 27, 2019

/check-cla

@nrdlngr nrdlngr force-pushed the master branch 2 times, most recently from bfc73cf to ac5dd5c Compare June 27, 2019 23:04
@nrdlngr
Copy link
Contributor Author

nrdlngr commented Jun 27, 2019

I signed it.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 27, 2019
@nrdlngr
Copy link
Contributor Author

nrdlngr commented Jun 27, 2019

/assign @idvoretskyi

@nrdlngr
Copy link
Contributor Author

nrdlngr commented Jul 2, 2019

@idvoretskyi @sebgoa can either of you help move this PR along? The guestbook-go example has been broken for a while now, and this fixes it.

Copy link
Member

@idvoretskyi idvoretskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 2, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: idvoretskyi, nrdlngr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 2, 2019
@idvoretskyi
Copy link
Member

@nrdlngr sorry for the delay, missed out from the radar.

Approved now, should be good to go.

@k8s-ci-robot k8s-ci-robot merged commit 97c7ed0 into kubernetes:master Jul 2, 2019
@nrdlngr
Copy link
Contributor Author

nrdlngr commented Jul 2, 2019

Thanks @idvoretskyi!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kubernetes/redis-slave:v2 image does not exist
3 participants