Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update guidelines.md #60

Merged
merged 3 commits into from
Aug 15, 2017
Merged

Update guidelines.md #60

merged 3 commits into from
Aug 15, 2017

Conversation

hzxuzhonghu
Copy link
Member

No description provided.

@ahmetb
Copy link
Member

ahmetb commented Aug 14, 2017

I think the cluster/kubectl.sh note is pretty obsolete at this point. Can you please remove this item completely?

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 14, 2017
@ahmetb ahmetb self-requested a review August 14, 2017 22:34
@ahmetb ahmetb self-assigned this Aug 14, 2017
@hzxuzhonghu
Copy link
Member Author

@ahmetb ok, i will remove it.

@ahmetb
Copy link
Member

ahmetb commented Aug 15, 2017

Sorry, I meant to remove this sentence altogether. kubectl is pretty much the only option, so saying "Use kubectl" alone sounds a bit strange.

@hzxuzhonghu
Copy link
Member Author

ok, I know

@ahmetb
Copy link
Member

ahmetb commented Aug 15, 2017

Thank you!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 15, 2017
@ahmetb ahmetb merged commit ea53276 into kubernetes:master Aug 15, 2017
@hzxuzhonghu hzxuzhonghu deleted the patch-1 branch August 15, 2017 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmetb ahmetb Awaiting requested review from ahmetb

Assignees

@ahmetb ahmetb

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hzxuzhonghu @ahmetb @k8s-ci-robot