profile <name>: error acquiring lock for x: Name "-x" not valid

[galderz]

Trying Minikube 1.4.0 and seeing this error when setting the profile name:

minikube profile operator-minikube
😿  Error while setting kubectl current context :  writing kubeconfig: Error writing file operator-minikube: error acquiring lock for operator-minikube: Name "-operator-minikube" not valid

Seems like a bug? I did prefix any - into the profile name.

[tstromberg]

Yup, this is definitely a bug.

 ~  minikube profile y
✅  Created a new profile : y
😿  Error while setting kubectl current context :  writing kubeconfig: Error writing file y: error acquiring lock for y: Name "-y" not valid
✅  minikube profile was successfully set to y

[afbjorklund]

Apparently mutex cannot use the name that itself constructs (by escaping stuff with dashes)

	validName = regexp.MustCompile("^[a-zA-Z][a-zA-Z0-9-]*$")

[afbjorklund]

Something is definitely weird with those CurrentContext functions, and the parameter order.

cmd/minikube/cmd/config/profile.go:                             err := kubeconfig.SetCurrentContext(constants.KubeconfigPath, profile)
pkg/minikube/kubeconfig/context.go:func SetCurrentContext(name string, configPath ...string) error {

cmd/minikube/cmd/stop.go:       err = kubeconfig.UnsetCurrentContext(constants.KubeconfigPath, machineName)
pkg/minikube/kubeconfig/context.go:func UnsetCurrentContext(machineName string, configPath ...string) error {

See how path and name is sent to name and path ? That sounds wrong...

[afbjorklund]

Bettter now, it actually locks ~/.kube/config instead of trying to lock ./foo (and failing miserably)

Also fixed the similar issue where minikube stop failed to match the current context name (with path)