Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix kicbase dockerfile to allow ppc64le and armv7 archs #13124

Merged
merged 20 commits into from
Dec 15, 2021
Merged

fix kicbase dockerfile to allow ppc64le and armv7 archs #13124

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
6b7168c
fix kicbase dockerfile to allow ppc64le and armv7 archs
sharifelgamal Dec 8, 2021
b9e9df1
return better error
sharifelgamal Dec 8, 2021
da7020a
format error message EVEN BETTER
sharifelgamal Dec 8, 2021
6c7cf29
exclude crio for powerpc
sharifelgamal Dec 8, 2021
a8ca32e
filter out podman for powerpc arch
sharifelgamal Dec 8, 2021
ba5e3d4
don't stop services that aren't installed
sharifelgamal Dec 8, 2021
9700ca1
don't start podman socket when there is no podman
sharifelgamal Dec 8, 2021
0e00ca4
syntax
sharifelgamal Dec 8, 2021
72e654a
don't add user to nonexistent group :)
sharifelgamal Dec 8, 2021
50ed250
don't use crio on armv7 either
sharifelgamal Dec 13, 2021
2d12be0
detect arm better
sharifelgamal Dec 13, 2021
682d144
fix sed for ppc
sharifelgamal Dec 13, 2021
3733f43
death by a thousand papercuts
sharifelgamal Dec 13, 2021
885ad28
fix it actually
sharifelgamal Dec 14, 2021
efe0dd7
Updating kicbase image to v0.0.28-1639444036-13124
minikube-bot Dec 14, 2021
c3688b6
address comments
sharifelgamal Dec 14, 2021
cf64c36
Merge branch 'kicbase-arch' of github.com:sharifelgamal/minikube into…
sharifelgamal Dec 14, 2021
1c94864
spacing
sharifelgamal Dec 14, 2021
b70736a
remove unused error code
sharifelgamal Dec 14, 2021
a6ef730
Updating kicbase image to v0.0.28-1639515145-13124
minikube-bot Dec 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
format error message EVEN BETTER
  • Loading branch information
@sharifelgamal
sharifelgamal committed Dec 8, 2021
commit da7020aa9cfef320eb8c0f94a4e1532c6c7e239b
2 changes: 1 addition & 1 deletion cmd/minikube/cmd/start.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1286,7 +1286,7 @@ func validateRuntime(rtime string) error {
}

if (rtime == "crio" || rtime == "cri-o") && strings.HasPrefix(runtime.GOARCH, "ppc64") {
return errors.New("The CRI-O runtime is not compatible with the ppc architecture.")
out.Error(reason.RuntimeIncompat, "The {{.runtime}} runtime is not compatible with the {{.arch}} architecture.", out.V{"runtime": rtime, "arch": runtime.GOARCH})
sharifelgamal marked this conversation as resolved.
Show resolved Hide resolved
}

if !validRuntime {
Expand Down
2 changes: 2 additions & 0 deletions pkg/minikube/reason/reason.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,6 +402,8 @@ var (
RuntimeEnable = Kind{ID: "RUNTIME_ENABLE", ExitCode: ExRuntimeError}
// minikube failed to cache images for the current container runtime
RuntimeCache = Kind{ID: "RUNTIME_CACHE", ExitCode: ExRuntimeError}
// the chosen container runtime doesn't work with the system architecture
RuntimeIncompat = Kind{ID: "RUNTIME_INCOMPAT", ExitCode: ExRuntimeError}

// service check timed out while starting minikube dashboard
SvcCheckTimeout = Kind{ID: "SVC_CHECK_TIMEOUT", ExitCode: ExSvcTimeout}
Expand Down