Retain folder structure when copying files in ~/.minikube/files

[mmhelm]

Renamed function parameter vmpath to vmbasedir in order to prevent overwriting it in the filepath.Walk function. #2768

[minikube-bot]

Can one of the admins verify this patch?

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mmhelm
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: dlorenc

If they are not already assigned, you can assign the PR to them by writing /assign @dlorenc in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mmhelm]

/assign @dlorenc

[mmhelm]

/assign @r2d4

[dlorenc]

Renamed function parameter vmpath to vmbasedir in order to prevent overwriting it in the filepath.Walk function. #2768

Do you have a test-case we could add to help make sure this fixes the issue and doesn't regress?

[mmhelm]

Not yet. I've extracted the function code to a simple main function and tried it manually.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[tstromberg]

Not yet. I've extracted the function code to a simple main function and tried it manually.

Before approving this, I would really like to see a unit or integration test of some sort to validate that we don't break this in the future.

[tstromberg]

@minikube-bot OK to test

[tstromberg]

I believe this was obsoleted by #3501