Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run pnpm lagon dev will throw module not found error #86

Closed
await-ovo opened this issue Jul 11, 2022 · 3 comments · Fixed by #87
Closed

run pnpm lagon dev will throw module not found error #86

await-ovo opened this issue Jul 11, 2022 · 3 comments · Fixed by #87
Labels

Comments

@await-ovo
Copy link
Contributor

Describe the bug
A clear and concise description of what the bug is.

Pasted Graphic 1 copy

To Reproduce
Steps to reproduce the behavior:

  1. mkdir test-lagon && cd test-lagon
  2. pnpm init && pnpm add @lagon/cli
  3. pnpm lagon dev
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

The command can be executed successfully.

Information:

  • OS: macOS
  • Node.js Version: v16.15.1

It seems related to esbuild external dependencies with esm format(evanw/esbuild#1958).

@QuiiBz
Copy link
Member

QuiiBz commented Jul 11, 2022

Good catch! Left a review in your PR, thanks.

@QuiiBz
Copy link
Member

QuiiBz commented Jul 11, 2022

Btw, let me create an issue to not forgot about adding more tests to catch those issues in the future.

@QuiiBz
Copy link
Member

QuiiBz commented Jul 12, 2022

Published version 0.0.7 of @lagon/cli, you should be able to update to get the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants