Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PQ assignment stage HashMap lookups are too slow at 1B rows #2518

Open
westonpace opened this issue Jun 24, 2024 · 1 comment
Open

PQ assignment stage HashMap lookups are too slow at 1B rows #2518

westonpace opened this issue Jun 24, 2024 · 1 comment

Comments

@westonpace
Copy link
Contributor

We don't need a HashMap anyways. Since we're mapping from row address to partition id we can use a Vec<Vec<...>> where each lookup is map[fragment_id][row_offset]. From some experimentation this is ~6x faster.
@westonpace
Copy link
Contributor Author

860d002 demonstrates the fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@westonpace