Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shuffling stage is too slow #2519

Open
westonpace opened this issue Jun 24, 2024 · 2 comments
Open

Shuffling stage is too slow #2519

westonpace opened this issue Jun 24, 2024 · 2 comments

Comments

@westonpace
Copy link
Contributor

When training an index the shuffling stage runs too slowly. This seems to be because we are storing 1 batch per partition (even empty partitions need a batch) and there is a lot of concatenation. By storing a list array we can avoid both problems and the shuffling can actually completely quite quickly (in theory as fast as 6 minutes for 1B rows but might need many CPUs / RAM to achieve). At the very least we should be able to finish in 1-2 hours.

@westonpace
Copy link
Contributor Author

5709bcd describes a potential fix

@westonpace
Copy link
Contributor Author

westonpace commented Jun 24, 2024

Also need c59478b and 7f86689 (but this last one could use some tweaking, I think it creates too many sorted partition files)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant