Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add gpt-4o-2024-08-06 and json_schema for azure openAI service #7648

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

hjlarry
Copy link
Contributor

@hjlarry hjlarry commented Aug 26, 2024

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

Fixes #7636

  1. add gpt-4o-2024-08-06 model
  2. support json_schema for gpt-4o-2024-08-06 and gpt-4o-mini-2024-07-18

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

NOT TEST

I haven't got an azure key, please help to test it, thanks! @liaopen123 @crazywoola

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. ⚙️ feat:model-runtime 💪 enhancement New feature or request labels Aug 26, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 4, 2024
@crazywoola crazywoola merged commit 3e7597f into langgenius:main Sep 4, 2024
6 checks passed
@@ -276,12 +277,18 @@ def _chat_generate(self, model: str, credentials: dict,

response_format = model_parameters.get("response_format")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moto g 72

@@ -276,12 +277,18 @@ def _chat_generate(self, model: str, credentials: dict,

response_format = model_parameters.get("response_format")
if response_format:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5515689829

@@ -1,4 +1,5 @@
import copy
import json

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 enhancement New feature or request ⚙️ feat:model-runtime lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Any plan on supporting other model vendors(Azure OpenRouter) structured outputs?
3 participants