Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: update app published time after clicking publish button #7801

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

vicoooo26
Copy link
Contributor

@vicoooo26 vicoooo26 commented Aug 29, 2024

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

The component App Publisher always displays app published time info by publishedAt in initial props, and it won't update the published time even if our users click the publish button.
This PR adds a new state and uses publishedAt as the initial state value. Once our users succeed in publishing an App, the published time will get updated to the current time.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Click to publish an App
  • The published time gets updated
  • Do not refresh the page and toggle the publish modal several times, the published time displays correctly in the corresponding format. 

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. 💪 enhancement New feature or request labels Aug 29, 2024
@crazywoola crazywoola requested a review from zxhlyh August 29, 2024 08:23
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 4, 2024
@crazywoola crazywoola merged commit 0bc19c3 into langgenius:main Sep 4, 2024
3 checks passed
@crazywoola crazywoola mentioned this pull request Sep 12, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 enhancement New feature or request lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants