FIX: setting source values #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the creation of vsource from circuit to use correct values for mvasc3,mvasc1 and isc3,isc1 if one of the pair is not specified. Default values in documentation are not consistent with software for ISC(1|3) Updates unit tests and changelog Closes #176
pseudocubic
added
Type: Bug
Codecov Report
@@ Coverage Diff @@
## master #178 +/- ##
==========================================
- Coverage 85.93% 85.91% -0.02%
==========================================
Files 39 39
Lines 4109 4105 -4
==========================================
- Hits 3531 3527 -4
Misses 578 578
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the creation of vsource from circuit to use correct values for mvasc3,mvasc1 and isc3,isc1 if one of the pair is not specified.
Default values in documentation are not consistent with software for ISC(1|3)
Updates unit tests and changelog
Closes #176