Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: property assignment in different file #420

Merged
merged 1 commit into from
Jan 4, 2023
Merged

Conversation

pseudocubic
Copy link
Collaborator

Fixes a bug where if a property is assigned via the pattern, e.g.,

load.a1.bus1 = some_bus

in a file that is different from the one where load.a1 was defined, the assignment would fail.

Closes #397

Fixes a bug where if a property is assigned via the pattern, e.g.,

`load.a1.bus1 = some_bus`

in a file that is different from the one where `load.a1` was defined, the assignment would fail.

Closes #397
@pseudocubic pseudocubic added Type: Bug Something isn't working Category: Data Parsers parser issues labels Jan 4, 2023
@pseudocubic pseudocubic self-assigned this Jan 4, 2023
@codecov
Copy link

codecov bot commented Jan 4, 2023

Codecov Report

Merging #420 (2401819) into main (748c4ce) will increase coverage by 0.20%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #420      +/-   ##
==========================================
+ Coverage   71.46%   71.67%   +0.20%     
==========================================
  Files          60       60              
  Lines       15194    15193       -1     
==========================================
+ Hits        10859    10890      +31     
+ Misses       4335     4303      -32     
Impacted Files Coverage Δ
src/io/dss/dss_parse.jl 90.12% <100.00%> (-2.74%) ⬇️
src/form/acp.jl 64.66% <0.00%> (+0.15%) ⬆️
src/form/bf_fbs.jl 96.86% <0.00%> (+0.22%) ⬆️
src/form/fotr.jl 97.27% <0.00%> (+0.24%) ⬆️
src/form/bf_mx_lin.jl 88.12% <0.00%> (+0.27%) ⬆️
src/form/fotp.jl 94.49% <0.00%> (+0.28%) ⬆️
src/data_model/units.jl 87.35% <0.00%> (+0.29%) ⬆️
src/io/utils.jl 82.50% <0.00%> (+0.38%) ⬆️
src/io/dss/dss2eng.jl 91.73% <0.00%> (+0.40%) ⬆️
... and 8 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pseudocubic pseudocubic merged commit c226f7a into main Jan 4, 2023
@pseudocubic pseudocubic deleted the fix-dss-assign-prop branch January 4, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Data Parsers parser issues Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] parse_file don't change an element when a .dss file change it.
1 participant