ADD: Capacitor control for IVR and FOTP formulations #404
Conversation
Codecov Report
@@ Coverage Diff @@
## main #404 +/- ##
==========================================
+ Coverage 69.69% 70.14% +0.44%
==========================================
Files 59 59
Lines 14652 14831 +179
==========================================
+ Hits 10212 10403 +191
+ Misses 4440 4428 -12
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
src/form/ivr.jl
Outdated
| """ | ||
| variable_mc_capcontrol(pm::AbstractUnbalancedIVRModel; nw::Int=nw_id_default, relax::Bool=false, report::Bool=true) | ||
|
|
||
| Capacitor switching variables. | ||
| """ | ||
| function variable_mc_capcontrol(pm::AbstractUnbalancedIVRModel; nw::Int=nw_id_default, relax::Bool=false, report::Bool=true) | ||
| variable_mc_capacitor_switch_state(pm; nw=nw, relax=relax, report=report) | ||
| end | ||
|
|
||
|
|
There was a problem hiding this comment.
Is this necessary? Is having a function with pm::AbstractUnbalancedPowerModels would be enough, I don't see any custom version of variable_mc_capacitor_switch_state for IVR
There was a problem hiding this comment.
It might not be necessary. I think the other formulations (ACP, ACR) also have individual variable_mc_capcontrol but call the same variable_mc_capacitor_switch_state function. I can modify this and create a single variable_mc_capcontrol(pm::AbstractUnbalancedPowerModels;...) that should work for all formulations.
There was a problem hiding this comment.
yes, let's do that. the current way seems redundant, and this would reduce the amount of code we need to maintain in the future
There was a problem hiding this comment.
The changes have been made. Also, FOTP formulation did not have CapControl and the feature has now been added (changed the PR description accordingly).
keatsig
changed the title
pseudocubic
added
Type: Enhancement
This PR adds capacitor control to current-voltage variable space (IVR) and first-order Taylor polar (FOTP) formulations. This control emulates a typical utility wye-connected capacitor by sending switching messages.