FIX: dss parsing of object names with '.' char #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug where dss allows for '.' characters in the name of the object, but we were previously splitting on all '.' chars, causing us to drop part of the name in some cases. Resolves #441
pseudocubic
added
Type: Bug
Codecov Report
@@ Coverage Diff @@
## main #444 +/- ##
=======================================
Coverage 73.79% 73.79%
=======================================
Files 72 72
Lines 16301 16301
=======================================
Hits 12030 12030
Misses 4271 4271
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
the sbase_scale_factor=1.0 was causing SCS solver problems, adjusted to 100.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where dss allows for '.' characters in the name of the object, but we were previously splitting on all '.' chars, causing us to drop part of the name in some cases.
Resolves #441