[1.x] Adds tests against "openswoole" #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nunomaduro I'd personally keep this grouped under a single file as a different "job". The way we usually organise GHA workflows is to group specific "type" of workflows. Like framework: types, tests, database engines. Swoole and OpenSwoole tests basically test the actual working of Octane so it's best to keep these grouped under "tests.yml". All OS projects of Laravel also have a "tests.yml" file. |
|
Checking Dries... |
driesvints
reviewed
Nov 15, 2021
driesvints
reviewed
Nov 15, 2021
nunomaduro
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request duplicates the tests workflow, so we can test octane against "openswoole". A good news, seems that "open-swoole" is already compatible with PHP 8.1. Yet, "swoole" is not, so we are going to ignore the PHP 8.1 swoole build for now.