Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking the recipe cap of sawmill #6708

Open
3 tasks done
xXAnoHitoXx opened this issue Mar 10, 2021 · 6 comments
Open
3 tasks done

breaking the recipe cap of sawmill #6708

xXAnoHitoXx opened this issue Mar 10, 2021 · 6 comments
Assignees
Labels
Bug Gotta squash 'em all!

Comments

@xXAnoHitoXx
Copy link

Prerequisites

  • I am running the latest alpha version of MineColonies and Structurize for my Minecraft version.
  • I checked the MineColonies/Structurize wiki and made sure my issue is not covered there.
  • I made sure that this issue is not a duplicate of any existing issue.

Context

  • Minecraft Version: 1.16.5
  • MineColonies Version: 0.13.690-ALPHA
  • Structurize Version: 0.13.148-ALPHA
  • Related Mods and their Versions: none

Expected behavior

the number of recipe saved should be under the cap.

Actual behavior

the feature where the recipe for timber frame around wooden center is automatically added
to the sawmill ignore the total number of recipe the saw mill have.


2021-03-09_18 42 49

Steps to reproduce the issue

  1. Fill a saw mill completely with recipes, including a mix of player made recipe and auto generated ones, using a variety of wood types
  2. remove one or more of the auto-generated recipes to bring down the total number of recipes
  3. quickly add new recipes before the game updates and re-add those auto-generated ones
  4. close out the menu, wait a bit, open it again and you break the cap of recipes

Logs

  • latest.log:
  • crashlog:

Notes


Viewers

  • Add a thumbs-up to the bug report if you are also affected. This helps the bug report become more visible to the team and doesn't clutter the comments.
  • Add a comment if you have any insights or background information that isn't already part of the conversation.
@xXAnoHitoXx xXAnoHitoXx added the Bug Gotta squash 'em all! label Mar 10, 2021
@xXAnoHitoXx
Copy link
Author

submitting another report for the recipe visual display

@xXAnoHitoXx xXAnoHitoXx changed the title Visual Bug - changing order of recipe in recipe list breaking the recipe cap of sawmill Mar 10, 2021
@Mekle001 Mekle001 self-assigned this Mar 10, 2021
@Mekle001
Copy link
Contributor

Are you still seeing this in the most recent versions? There were several things wrong that could have caused this behavior that have been fixed recently.

@Mekle001 Mekle001 added the Awaiting Response Issue or PR that is awaiting a response. label Mar 20, 2021
@uecasm
Copy link
Contributor

uecasm commented Mar 20, 2021

The auto recipes being able to break the cap is somewhat intended, since there are buildings where there are more auto recipes than there are recipe slots. It could perhaps be a little better at not letting you exploit that, but it's only a very narrow window of time.

The mixed up visual displays were recently fixed, so as Mekle said they should no longer be an issue.

@xXAnoHitoXx
Copy link
Author

if is is intended, wouldn't it make more sense to not have the auto-generated recipe affect the total recipe counts at all, since it'd then be a proper feature oppose to a janky hoops hopity?

also it's still around in the newest version.

@ravenbuilder934 ravenbuilder934 removed the Awaiting Response Issue or PR that is awaiting a response. label Mar 21, 2021
@Mekle001
Copy link
Contributor

Mekle001 commented Mar 22, 2021

There are several things here.

  1. We have cases where we ignore the counts entirely. A level 1 lumberjack has 4 recipes which breaks the limit, but you can't teach it recipes, so it really doesn't matter.
  2. Sometimes, the recipes DO need to count against the limit. Timberframes particularly. They are intended to replace something that already is there. (There was a bug where they were getting triggered to be added inappropriately, now mostly stomped)
  3. We don't currently have a way to indicate that there are not-yet added recipes, so we can't block adding auto-added recipes currently.

This isn't even getting into the complexity of how we track that a recipe was auto-added if it happens to be improved (cost reduced) as it isn't even the same recipe anymore.

@SinFlame
Copy link

SinFlame commented Apr 1, 2021

Dev, maybe make a different tab for custom recipe and recipes added by the hut?
It's like a bonus, and it shouldnt add to the count

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Gotta squash 'em all!
Projects
None yet
Development

No branches or pull requests

5 participants