Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manual release created (v0.24.2) #854

Closed
github-actions bot opened this issue Jun 20, 2023 · 2 comments
Closed

manual release created (v0.24.2) #854

github-actions bot opened this issue Jun 20, 2023 · 2 comments
Assignees

Comments

@github-actions
Copy link

@Jorropo just pushed a release tag: v0.24.2.
Please manually verify validity (using `gorelease`), and update `version.json` to reflect the manually released version, if necessary.
In the future, please use the automated process.

@Jorropo
Copy link
Contributor

Jorropo commented Jun 20, 2023

cc @galargh I tried the instruction but:

  1. no release label were existing, so I made a new one idk if it's correct.
  2. it didn't do the release

#853

@Jorropo Jorropo closed this as not planned Won't fix, can't repro, duplicate, stale Jun 20, 2023
@galargh
Copy link
Contributor

galargh commented Jun 20, 2023

The tag gets created after the merge. I can see that the release check created the draft release (https://github.com/libp2p/go-libp2p-kad-dht/actions/runs/5317866054/jobs/9628796756) and that the releaser workflow run after the merge but the tag already existed - https://github.com/libp2p/go-libp2p-kad-dht/actions/runs/5317898171/jobs/9628857314. Did you create the tag before merge?

Also, when you're merging to the default branch, you don't need the label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants