This repository has been archived by the owner on Jun 26, 2023. It is now read-only.
fix: update pubsub types #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes `PubSub` to not be a generic type as we don't know the event types that will be emitted ahead of time. Also, the message types for anything that isn't a subscription change is the same so there's little to gain type-wise from requiring knowledge of the event types.
github-actions bot
pushed a commit
that referenced
this pull request
Mar 20, 2022
## [@libp2p/interfaces-v1.3.16](https://github.com/libp2p/js-libp2p-interfaces/compare/@libp2p/interfaces-v1.3.15...@libp2p/interfaces-v1.3.16) (2022-03-20) ### Bug Fixes * update pubsub types ([#183](#183)) ([7ef4baa](7ef4baa))
|
🎉 This PR is included in version @libp2p/interfaces-v1.3.16 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
Mar 20, 2022
## [@libp2p/pubsub-v1.2.11](https://github.com/libp2p/js-libp2p-interfaces/compare/@libp2p/pubsub-v1.2.10...@libp2p/pubsub-v1.2.11) (2022-03-20) ### Bug Fixes * update pubsub types ([#183](#183)) ([7ef4baa](7ef4baa))
|
🎉 This PR is included in version @libp2p/pubsub-v1.2.11 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
Mar 20, 2022
## [@libp2p/interface-compliance-tests-v1.1.18](https://github.com/libp2p/js-libp2p-interfaces/compare/@libp2p/interface-compliance-tests-v1.1.17...@libp2p/interface-compliance-tests-v1.1.18) (2022-03-20) ### Bug Fixes * update pubsub types ([#183](#183)) ([7ef4baa](7ef4baa))
|
🎉 This PR is included in version @libp2p/interface-compliance-tests-v1.1.18 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
PubSubto not be a generic type as we don't know the event types that will be emitted ahead of time. Also, the message types for anything that isn't a subscription change is the same so there's little to gain type-wise from requiring knowledge of the event types.