From 1c90b71b9a5029022ee39412fc5eecd083ab905a Mon Sep 17 00:00:00 2001 From: achingbrain Date: Mon, 10 Aug 2020 19:13:14 +0100 Subject: [PATCH 1/2] chore: upgrade deps BREAKING CHANGES: - All deps of this module now use Uint8Arrays instead of node Buffers --- package.json | 9 ++++----- src/compat/responder.js | 1 + test/multicast-dns.spec.js | 5 +---- 3 files changed, 6 insertions(+), 9 deletions(-) diff --git a/package.json b/package.json index 1ac1fe8..d9f3eb2 100644 --- a/package.json +++ b/package.json @@ -35,18 +35,17 @@ "homepage": "https://github.com/libp2p/js-libp2p-mdns", "devDependencies": { "aegir": "^25.0.0", - "chai": "^4.2.0", "delay": "^4.3.0", - "dirty-chai": "^2.0.1", - "libp2p-interfaces": "^0.3.0", + "libp2p-interfaces": "^0.4.0", "p-defer": "^3.0.0", "p-wait-for": "^3.1.0" }, "dependencies": { + "buffer": "^5.6.0", "debug": "^4.1.1", - "multiaddr": "^7.5.0", + "multiaddr": "^8.0.0", "multicast-dns": "^7.2.0", - "peer-id": "^0.13.13" + "peer-id": "^0.14.0" }, "contributors": [ "David Dias ", diff --git a/src/compat/responder.js b/src/compat/responder.js index bcaa295..b825d3d 100644 --- a/src/compat/responder.js +++ b/src/compat/responder.js @@ -4,6 +4,7 @@ const OS = require('os') const MDNS = require('multicast-dns') const log = require('debug')('libp2p:mdns:compat:responder') const { SERVICE_TAG_LOCAL } = require('./constants') +const { Buffer } = require('buffer') class Responder { constructor ({ peerId, multiaddrs }) { diff --git a/test/multicast-dns.spec.js b/test/multicast-dns.spec.js index 4b4dd51..c7a04d2 100644 --- a/test/multicast-dns.spec.js +++ b/test/multicast-dns.spec.js @@ -1,10 +1,7 @@ /* eslint-env mocha */ 'use strict' -const chai = require('chai') -const dirtyChai = require('dirty-chai') -const expect = chai.expect -chai.use(dirtyChai) +const { expect } = require('aegir/utils/chai') const multiaddr = require('multiaddr') const PeerId = require('peer-id') const pWaitFor = require('p-wait-for') From 76464ac3b385716d41f85184c4482f3d382a4408 Mon Sep 17 00:00:00 2001 From: achingbrain Date: Tue, 11 Aug 2020 12:10:32 +0100 Subject: [PATCH 2/2] chore: address pr comments --- package.json | 1 - src/compat/responder.js | 1 - test/compat/go-multicast-dns.spec.js | 6 +----- test/compat/querier.spec.js | 5 +---- test/compat/responder.spec.js | 6 +----- 5 files changed, 3 insertions(+), 16 deletions(-) diff --git a/package.json b/package.json index d9f3eb2..13996dc 100644 --- a/package.json +++ b/package.json @@ -41,7 +41,6 @@ "p-wait-for": "^3.1.0" }, "dependencies": { - "buffer": "^5.6.0", "debug": "^4.1.1", "multiaddr": "^8.0.0", "multicast-dns": "^7.2.0", diff --git a/src/compat/responder.js b/src/compat/responder.js index b825d3d..bcaa295 100644 --- a/src/compat/responder.js +++ b/src/compat/responder.js @@ -4,7 +4,6 @@ const OS = require('os') const MDNS = require('multicast-dns') const log = require('debug')('libp2p:mdns:compat:responder') const { SERVICE_TAG_LOCAL } = require('./constants') -const { Buffer } = require('buffer') class Responder { constructor ({ peerId, multiaddrs }) { diff --git a/test/compat/go-multicast-dns.spec.js b/test/compat/go-multicast-dns.spec.js index 4c572bc..6c40e3b 100644 --- a/test/compat/go-multicast-dns.spec.js +++ b/test/compat/go-multicast-dns.spec.js @@ -1,11 +1,7 @@ /* eslint-env mocha */ 'use strict' -const chai = require('chai') -const dirtyChai = require('dirty-chai') -const expect = chai.expect -chai.use(dirtyChai) - +const { expect } = require('aegir/utils/chai') const multiaddr = require('multiaddr') const PeerId = require('peer-id') const pDefer = require('p-defer') diff --git a/test/compat/querier.spec.js b/test/compat/querier.spec.js index 247153b..9fb3ab7 100644 --- a/test/compat/querier.spec.js +++ b/test/compat/querier.spec.js @@ -1,10 +1,7 @@ /* eslint-env mocha */ 'use strict' -const chai = require('chai') -const dirtyChai = require('dirty-chai') -const expect = chai.expect -chai.use(dirtyChai) +const { expect } = require('aegir/utils/chai') const PeerId = require('peer-id') const MDNS = require('multicast-dns') const OS = require('os') diff --git a/test/compat/responder.spec.js b/test/compat/responder.spec.js index 7db842d..e49ae8e 100644 --- a/test/compat/responder.spec.js +++ b/test/compat/responder.spec.js @@ -1,11 +1,7 @@ /* eslint-env mocha */ 'use strict' -const chai = require('chai') -const dirtyChai = require('dirty-chai') -const expect = chai.expect -chai.use(dirtyChai) - +const { expect } = require('aegir/utils/chai') const multiaddr = require('multiaddr') const PeerId = require('peer-id') const MDNS = require('multicast-dns')