This repository has been archived by the owner on Jul 21, 2023. It is now read-only.
fix: remove MPLEX_ prefix from error codes #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To allow detecting the same error condition with different stream muxer implementations, remove the `MPLEX_` prefix from the error codes thrown by this module. Also adds a `ERR_DOUBLE_SINK` code when when `.sink` is called multiple times instead of only throwing `ERR_SINK_ENDED` when `.sink` is called after a stream is closed for reading. Refs: ChainSafe/js-libp2p-yamux#4
github-actions bot
pushed a commit
that referenced
this pull request
Jul 25, 2022
## [4.0.2](v4.0.1...v4.0.2) (2022-07-25) ### Bug Fixes * remove MPLEX_ prefix from error codes ([#195](#195)) ([c6c9581](c6c9581))
|
🎉 This PR is included in version 4.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow detecting the same error condition with different stream
muxer implementations, remove the
MPLEX_prefix from the errorcodes thrown by this module.
Also adds a
ERR_DOUBLE_SINKcode when when.sinkis calledmultiple times instead of only throwing
ERR_SINK_ENDEDwhen.sinkis called after a stream is closed for reading.
Refs: ChainSafe/js-libp2p-yamux#4